refactor(server): move asset detail endpoint to new controller #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4735b9a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad497ddf.immich.pages.dev |
| Branch Preview URL: | https://refactor-asset-by-id.immich.pages.dev |
jrasm91
commented
Jan 25, 2024
danieldietzler
approved these changes
Jan 25, 2024
jrasm91
force-pushed
the
refactor/asset-by-id
branch
from
ce00023 to
4735b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
/asset/assetById/:idis deprecated and will be removed in a future release*V1everywhere/asset/:idendpoint (in the new controller)Note: A lot of relations where loaded for
serveFile, but now it should just load the asset, so that endpoint should be faster.