-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): album description #6512
Conversation
const autoGrowHeight = () => { | ||
// little hack so that the height of the text area is correctly initialized | ||
textarea.scrollHeight; | ||
textarea.style.height = '5px'; | ||
textarea.style.height = `${textarea.scrollHeight}px`; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you just copied and pasted all of this stuff. Can you re-implement this without copy/pasting please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you want me to change ?
Just put it in a .ts
file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe look into a way to:
- add a directive/attribute/use:autogrow thing that will just do it automatically
- add a custom
TextArea
component that we can use everywhere we want a text box
also what is line 154?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without it, the textarea height is not correctly initialized:
2024-01-19.22-45-01.mp4
Hey @martabal it looks like this issue still happens on the album page if shared. Running latest 1.93.3 To recreate share the test album and open the share link. |
@ndragon798 this PR is merged but hasn't been released yet. It will be available in the next release |
Ah alright I thought it was included. |
Changes made in this PR
Screenshots
2024-01-19.20-30-23.mp4