feat(web): store accordion state in search params #6435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
2bf722a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce448c09.immich.pages.dev |
| Branch Preview URL: | https://refactor-admin-settings-acco.immich.pages.dev |
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
2 times, most recently
from
4e5e0c4 to
31858cd
Compare
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
2 times, most recently
from
4dbc892 to
f9aa4e2
Compare
danieldietzler
changed the title
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
f9aa4e2 to
4793fe7
Compare
martabal
reviewed
Jan 27, 2024
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
4793fe7 to
e366e93
Compare
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
e366e93 to
3d6f2f5
Compare
danieldietzler
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
3d6f2f5 to
d484ccc
Compare
jrasm91
approved these changes
Feb 9, 2024
jrasm91
force-pushed
the
refactor/admin-settings-accordions-state
branch
from
a1aa4bb to
52aac3a
Compare
jrasm91
changed the title
martabal
approved these changes
Feb 10, 2024
web/src/lib/components/admin-page/settings/setting-accordion.svelte
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to store the state of accordions (
isOpen?) in the URL. If an accordion component gets a keyfoo, this key will be used in the URL. (i.e.demo.immich.app/admin/system-settings?isOpen=foo)