-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add keyboard shortcut to stack selected photos #5983
Conversation
When can this get merged? |
The logic to stack assets already exist in https://github.com/immich-app/immich/blob/main/web/src/lib/components/photos-page/actions/stack-action.svelte. Can you use the same logic for the menu option and the shortcut action ? |
I tried deduplicating the code, but I don't know if my changes follow best practices. |
This would be so handy! How close is a merge? |
Any chance this can get merged? It would be crazy helpful!! |
@Funk66 can you resolve the merge conflicts and then we can look at merging it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is my attempt at implementing #5143
I should say that I have zero experience with Svelte. I would be nice to reduce the duplication with
immich/web/src/lib/components/photos-page/actions/stack-action.svelte
Line 15 in 3edc87f
As a side note, it may seem confusing to some that the help dialog shows action shortcuts that only work in the asset-viewer page, and now this new one that only works in the asset-grid page. Perhaps these should be shown under different categories.