Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): handle backup iCloud asset #5508

Merged
merged 10 commits into from
Dec 7, 2023
Merged

feat(mobile): handle backup iCloud asset #5508

merged 10 commits into from
Dec 7, 2023

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Dec 5, 2023 •
edited
Loading

  1. Add a mechanism to handle backup iCloud asset
    1.2. Show iCloud download progress bar.
  2. Add an option to ignore iCloud assets being uploaded to the Immich server
  3. Move backup options to its own page

@alextran1502 alextran1502 mentioned this pull request Dec 5, 2023
Closed
3 tasks
@alextran1502 alextran1502 marked this pull request as ready for review December 6, 2023 22:01
fyfrey
fyfrey reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@fyfrey fyfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the separation into the new backup settings page! Left a few inline comments

mobile/lib/modules/backup/ui/current_backup_asset_info_box.dart Outdated Show resolved Hide resolved
mobile/lib/modules/backup/views/backup_options_page.dart Outdated Show resolved Hide resolved
@alextran1502 alextran1502 merged commit 2e59b07 into main Dec 7, 2023
17 checks passed
@alextran1502 alextran1502 deleted the feat/handle-icloud-asset branch December 7, 2023 15:53
@sdebruyn sdebruyn mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyfrey fyfrey fyfrey left review comments

@shenlong-tanwen shenlong-tanwen shenlong-tanwen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alextran1502 @fyfrey @shenlong-tanwen