refactor(mobile): cleanup image request pipeline on iOS #27481
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import Accelerate | ||
| import Foundation | ||
|
|
||
| class ImageRequest { | ||
| private let lock = UnfairLock() | ||
| private var _isCancelled = false | ||
| private var callback: ((Result<[String: Int64]?, any Error>) -> Void)? | ||
|
|
||
| var isCancelled: Bool { | ||
| lock.lock() | ||
| defer { lock.unlock() } | ||
| return _isCancelled | ||
| } | ||
|
|
||
| init(callback: @escaping (Result<[String: Int64]?, any Error>) -> Void) { | ||
|
Member
There was a problem hiding this comment. This probably shouldn't be nullable. |
||
| self.callback = callback | ||
| } | ||
|
|
||
| func cancel() { | ||
| lock.lock() | ||
| _isCancelled = true | ||
| let cb = callback | ||
| callback = nil | ||
| lock.unlock() | ||
|
|
||
| onCancel() | ||
| cb?(ImageProcessing.cancelledResult) | ||
| } | ||
|
|
||
| func finish(with result: Result<[String: Int64]?, any Error>) { | ||
| lock.lock() | ||
| let cb = callback | ||
| callback = nil | ||
| lock.unlock() | ||
|
|
||
| cb?(result) | ||
| } | ||
|
|
||
| func onCancel() {} | ||
|
|
||
| func encodeToPointer(_ data: Data) { | ||
| let length = data.count | ||
| let pointer = malloc(length)! | ||
| data.copyBytes(to: pointer.assumingMemoryBound(to: UInt8.self), count: length) | ||
| if isCancelled { | ||
| free(pointer) | ||
| return | ||
| } | ||
| finish(with: .success([ | ||
| "pointer": Int64(Int(bitPattern: pointer)), | ||
| "length": Int64(length), | ||
| ])) | ||
| } | ||
|
|
||
| func cgImageToPointer(_ cgImage: CGImage, format: vImage_CGImageFormat) throws { | ||
| var fmt = format | ||
|
LeLunZ marked this conversation as resolved.
|
||
| let buffer = try vImage_Buffer(cgImage: cgImage, format: fmt) | ||
| if isCancelled { | ||
| buffer.free() | ||
| return | ||
| } | ||
| finish(with: .success([ | ||
| "pointer": Int64(Int(bitPattern: buffer.data)), | ||
| "width": Int64(buffer.width), | ||
| "height": Int64(buffer.height), | ||
| "rowBytes": Int64(buffer.rowBytes), | ||
| ])) | ||
| } | ||
| } | ||
|
|
||
| class RequestRegistry<T: ImageRequest> { | ||
| private let lock = UnfairLock() | ||
| private var requests = [Int64: T]() | ||
|
|
||
| func add(requestId: Int64, request: T) { | ||
| lock.lock() | ||
| requests[requestId] = request | ||
| lock.unlock() | ||
| } | ||
|
|
||
| @discardableResult | ||
| func remove(requestId: Int64) -> T? { | ||
| lock.lock() | ||
| defer { lock.unlock() } | ||
| return requests.removeValue(forKey: requestId) | ||
| } | ||
|
|
||
| func cancel(requestId: Int64) { | ||
| remove(requestId: requestId)?.cancel() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a lock?