fix(web): add delete confirmation in asset viewer#27303
Closed
timonrieger wants to merge 2 commits intomainfrom
Closed
fix(web): add delete confirmation in asset viewer#27303timonrieger wants to merge 2 commits intomainfrom
timonrieger wants to merge 2 commits intomainfrom
Conversation
Prompt for confirmation before moving a single asset to trash from the asset viewer to reduce accidental deletions. Made-with: Cursor
timonrieger
force-pushed
the
fix/web-asset-viewer-delete-confirmation
branch
from
ba42f95 to
eaef1a2
Compare
Member
danieldietzler
left a comment
danieldietzler
left a comment
There was a problem hiding this comment.
Oh I wasn't aware we do already show a modal when force deleting. I suppose trashing an asset isn't actually a destructive action. We probably don't need a confirmation here then, sorry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#27000 (review)