fix(server): don't delete offline library files from disk#27242
Closed
fix(server): don't delete offline library files from disk#27242
Conversation
etnoy
force-pushed
the
fix/dont-delete-offline-library-files
branch
from
c37b18a to
d21c89c
Compare
Member
|
Is this actually still an issue? I thought this was fixed in #24355 |
Collaborator
Author
Oh, my bad. I did create a regression test and fixed the issue, but I never ran the test before my "fix". I'll take a look to see if this PR should just be adding the regression test for the future and close the linked issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14995 by not deleting offline files from disk