Skip to content

feat(web): focus on face-editor search input #27136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldietzler merged 4 commits into from
Mar 26, 2026
Merged

feat(web): focus on face-editor search input #27136

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7517ed
feat(web): (keep) focus on face-editor search
cratoo Mar 21, 2026
e531b4d
ensure that esc for closing still works
cratoo Mar 21, 2026
c20cc2d
forgotten commit...
cratoo Mar 21, 2026
e3519b5
bind on input element directly; get rid of unnecessary clutter
cratoo Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions web/src/lib/components/asset-viewer/face-editor/face-editor.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import { Button, Input, modalManager, toastManager } from '@immich/ui';
import { Canvas, InteractiveFabricObject, Rect } from 'fabric';
import { clamp } from 'lodash-es';
import { onMount } from 'svelte';
import { onMount, tick } from 'svelte';
import { t } from 'svelte-i18n';

interface Props {
Expand All @@ -27,6 +27,7 @@
let faceRect: Rect | undefined = $state();
let faceSelectorEl: HTMLDivElement | undefined = $state();
let scrollableListEl: HTMLDivElement | undefined = $state();
let searchInputEl: HTMLInputElement | null = $state(null);
let page = $state(1);
let candidates = $state<PersonResponseDto[]>([]);

Expand Down Expand Up @@ -81,6 +82,8 @@
onMount(async () => {
setupCanvas();
await getPeople();
await tick();
searchInputEl?.focus();
});

const imageContentMetrics = $derived.by(() => {
Expand Down Expand Up @@ -221,12 +224,15 @@

$effect(() => {
const rect = faceRect;
if (rect) {
const cvs = canvas;
if (rect && cvs) {
rect.on('moving', positionFaceSelector);
rect.on('scaling', positionFaceSelector);
cvs.on('object:modified', () => searchInputEl?.focus());
return () => {
rect.off('moving', positionFaceSelector);
rect.off('scaling', positionFaceSelector);
cvs.off('object:modified', () => searchInputEl?.focus());
};
}
});
Expand Down Expand Up @@ -290,7 +296,7 @@
};
</script>

<svelte:document use:shortcut={{ shortcut: { key: 'Escape' }, onShortcut: cancel }} />
<svelte:document use:shortcut={{ shortcut: { key: 'Escape' }, onShortcut: cancel, ignoreInputFields: false }} />

<div
id="face-editor-data"
Expand All @@ -310,7 +316,7 @@
<p class="text-center text-sm">{$t('select_person_to_tag')}</p>

<div class="my-3 relative">
<Input placeholder={$t('search_people')} bind:value={searchTerm} size="tiny" />
<Input placeholder={$t('search_people')} bind:value={searchTerm} bind:ref={searchInputEl} size="tiny" />
</div>

<div bind:this={scrollableListEl} class="h-62.5 overflow-y-auto mt-2">
Expand Down
Loading