fix(mobile): images loads sometimes cancel too early by LeLunZ · Pull Request #27067 · immich-app/immich

LeLunZ · 2026-03-20T00:59:24Z

Description

This PR fixes a critical bug where image loading requests were being prematurely cancelled.
I myself could often reproduce it when moving the app into the background, while others such as @uhthomas sometimes randomly had the issue.

This took way too long to investigate… But finally I have a complete overview of the problems!

Primary Bug
Our custom ImageStreamCompleter classes are tracking the listenerCount. If the listenerCount dropped to 1 (while the image is still loading) we assumed the UI widget has been detached (leaving only the cache listener), then we cancelled the underlying network request.

Yeah...this all sounds normal. Till you notice, that when memory usage spikes, flutter clears the image cache (literally clears all). Here the code
This then drops the cache listener. Our logic saw listenerCount == 1 assuming the UI widget had detached, and cancelled the active fetch. This means while images were loading, and this occurred, they just stopped loading.

Hidden Bug
While fixing the memory pressure issue, I discovered two hidden issues:

in addListener we previously called super.addListener before incrementing listenerCount. This allowed synchrounous callbacks to temporarily push the listener count into negative numbers (-1)
When an initialImage is provided ImageCache.putIfAbsent attaches its listener, receives the synchronous frame and (important) synchronously detaches itself. If the math had been correct listenerCount would have hit 0 and again killed the image request before the UI even attaches itself. This only didn't occur because of the -1 glitch from above...

Solution
I created a new CacheAwareListenerTrackerMixin to handle all listener tracking across both our completers.

The mixin saves a reference of the first listener thats attached (which is guaranteed the cache). We then also explicitly check if the last one remaining is the cache listener.
Listener Incrementing is now done correctly before calling super
If we set an image synchronously, we ignore the first synchronous detachment of the cache (as listeners shortly drop to 0 when a initial image was provided)

How Has This Been Tested?

Yes.
Scrolling through the timeline
Moving app to background
Running app with low ram emulator

Checklist:

I have carefully read CONTRIBUTING.md
I have performed a self-review of my own code
I have made corresponding changes to the documentation if applicable
I have no unrelated changes in the PR.
I have confirmed that any new dependencies are strictly necessary.
I have written tests for new code (if applicable)
I have followed naming conventions/patterns in the surrounding code
All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

added documentation
help with coming up with all test cases

uhthomas · 2026-03-20T01:08:49Z

This is nice, good work. If true, it explains pretty well the behaviour I've been seeing, especially around how some images would load, but then others would remain as thumbhashes, and the images which did this would change when scrolling in and out of view.

Copilot

Pull request overview

This PR addresses premature cancellation of in-flight image loads in the mobile app by centralizing and hardening ImageStreamCompleter listener tracking, especially around Flutter image-cache behavior under memory pressure and synchronous initial-image delivery.

Changes:

Introduces CacheAwareListenerTrackerMixin to unify listener counting and “last listener removed” detection.
Updates both custom stream completers to use the new mixin and fixes the previous listener-count ordering issue (increment before super.addListener).
Adjusts handling for initialImage to avoid cancellation during synchronous cache attach/detach.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
mobile/lib/presentation/widgets/images/one_frame_multi_image_stream_completer.dart	Switches one-frame completer to use centralized listener tracking mixin.
mobile/lib/presentation/widgets/images/cache_aware_listener_tracker.mixin.dart	Adds new mixin implementing cache-aware listener tracking and cancellation signaling.
mobile/lib/presentation/widgets/images/animated_image_stream_completer.dart	Switches animated completer to the mixin; threads `hadInitialImage` into setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uhthomas · 2026-03-20T02:03:28Z

The original code made some very strange assumptions around number of listeners, and what listeners they were. These strange assumptions have sort of carried over to the fix too - should we take a step back and think of whether there's a simpler way to do this?

LeLunZ · 2026-03-20T08:40:44Z

@uhthomas yes, these assumptions where actually done by me in #25984

It’s because addOnLastListenerRemovedCallback the method the framework provides only triggers when all listeners (cache included) have been removed.
this doesn’t work for us, as a cache listener only is removed when an image is provided.

The code previously just called cancel on the imageProvider in the ThumbnailWidget. This caused issues, as when you open another screen where it needs the same image, you won’t get it, as thumbnail cancels the request…

LeLunZ · 2026-03-20T08:45:02Z

@mertalev i would also really like if there is a easier method, or something that’s provided by the framework.

But too get this fast cancel behavior, without calling cancel through a widget, I couldn’t come up with something better.

I mean the whole process of cancelling when no one is listening, seems to be not what flutter intended with the image cache. So we are fighting the framework in some way...

…cancel call

…Completer

mertalev

@uhthomas Since you had issues with thumbnails, would you be able to do some testing and see if the PR addresses this?

@LeLunZ Have you tested that the cancellation is as responsive as before, i.e. it is cancelling just as quickly when it should?

* refactor listener tracking for image stream completers and fix early cancel call * fix: improve cache listener identification in image stream tracking * add documentation and test cases for listener tracking in ImageStreamCompleter * fix: remove unnecessary image provision flag from listener tracking * fix: override setImage method in cache aware listener tracker mixin * fix: rename test file

….0) (#101) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [immich-app/immich](https://github.com/immich-app/immich) | minor | `v2.6.3` → `v2.7.0` | --- ### Release Notes <details> <summary>immich-app/immich (immich-app/immich)</summary> ### [`v2.7.0`](https://github.com/immich-app/immich/releases/tag/v2.7.0) [Compare Source](immich-app/immich@v2.6.3...v2.7.0) ### v2.7.0 Welcome to Immich `v2.7.0`! This release includes enhancements to the asset viewer, security improvements, changes to the duplicate APIs and viewer, and a bunch of bug fixes. Keep reading below for the complete highlights and a note on the upcoming `v3.0.0` release. > \[!NOTE]\ > We're working on a managed backup service for Immich with end-to-end encrypted backups of your library to a remote datacentre where only you hold the keys. > > We've put together a quick survey (\~5 mins) to get a better idea of how you're backing things up today and what you'd actually want from something like this. Your answers help us figure out what to prioritise, so we'd really appreciate it if you took a few minutes to fill it out. > > Leave your email at the end if you're interested in joining our free closed beta when it's ready. > > <https://futo-backups-survey.immich.app/> #### Known limitations - The machine learning service on `amd64` currently requires the `>= x86-64-v2` microarchitecture. This will be patched in an upcoming patch release for backward compatibility with very old processors (before \~2010), but it will become a minimum requirement in 3.0. `arm64` is not affected by this change. #### Highlights - Remove from album (asset viewer) - Move to locked folder (folder page) - Editor shortcuts - Create a new face on-the-fly in the face tag editor - Resolve duplicates - Helmet configuration - Version check infrastructure - Notable fix: live photo and video download in Safari - Notable fix: escape HTML in the Panorama Photo Viewer ##### Remove from album The web has a new action, "Remove from album," available in the asset viewer that makes it easier to remove an asset from an album. This action is available to both album and asset owners. <img width="360" height="202" alt="image" src="https://github.com/user-attachments/assets/e5facb24-ed10-4adc-957a-37147cca5634" /> ##### Move to locked folder in the Folder view Similarly, the folder view now includes the "Move to locked folder" action. <img width="1900" height="762" alt="image" src="https://github.com/user-attachments/assets/c39e792b-81da-4c31-a23f-03f96853fe8e" /> ##### Editor shortcuts Users on the web can now edit with keyboard shortcuts. Press `e` to open the editor. Once in the editor, press `[` or `]` to rotate the asset +/- 90 degrees. Finally, save any changes and close the editor with `ENTER`. <https://github.com/user-attachments/assets/969de104-b02d-41a6-830b-3e1a49541d14> ##### Create a new face on-the-fly in the face tag editor You can now create a new face/person on the fly from the face tagging editor interface <img width="350" alt="image" src="https://github.com/user-attachments/assets/c39db0e3-da47-4421-9040-5f51650deee9" /> <img width="350" alt="image" src="https://github.com/user-attachments/assets/0c81a1ee-c54e-4167-9dff-95719fe44595" /> ##### Deduplication improvements The duplicate screen has gone through a bunch of iterations since it was first introduced all the way back in May, 2024. The latest release moves a bunch of logic from the client to the server, which now automatically suggests which asset to keep based on image size and EXIF data. Additionally, the new server implementation will automatically synchronize metadata, including albums, favorite status, rating, description, visibility, location, and tags. For more information about this process, see the new [documentation](https://docs.immich.app/features/duplicates-utility). ##### Helmet configuration You can now opt in to using a [Content Security Policy (CSP)](https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CSP) in Immich. The new environment variant `IMMICH_HELMET_FILE` accepts a boolean or a path to a [helmet](https://helmetjs.github.io/) configuration file. **Recommend action:** The team recommends setting `IMMICH_HELMET_FILE=true` to enable the default policy. Then, please let us know if you run into any issues with it. ##### Background and details Since Immich is deployed in so many different ways, it has been hard to figure out how to enable a CSP that would not conflict with or break existing installs that might use 3rd party map providers, custom CSS, embed Immich in an iframe, or other such features. In this release, we have added the ability to both opt in to a default policy and configure a custom one. To use the default policy, simply set the environment variable `IMMICH_HELMET_FILE=true`. To use a custom policy, set the environment variable to a path on disk (within the immich-server) that contains a valid helmet configuration (e.g. `IMMICH_HELMET_FILE=/opt/immich/helmet.json`). CSP can be used to control what scripts are allowed to run on the page, which domains to load images from, etc. Additionally, it can be used to configure headers for [Referrer-Policy](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Referrer-Policy), [X-Powered-By](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Powered-By), [X-Frame-Options](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Frame-Options), and others. ##### New version check infrastructure Prior to this release, instances that used the automatic version check feature would send HTTP requests to `github.com`. Now, we have set up a small service at `version.immich.cloud` to handle these types of requests. This avoids any privacy implications of connecting to `github.com` , as well as moves the request load to our own infrastructure. ##### Notable fix: live photo and video download in Safari When downloading files in Safari with the same name, it will simply overwrite the file instead of automatically renaming it. In this release, the still and motion parts of a live photo are now named differently to prevent this from happening. ##### Notable fix: escape HTML in panorama photo viewer In `v2.6.0`, we added the ability to show/view clip text in the panorama viewer, but introduced an XSS vulnerability, which has been fixed in this release. Interestingly, this was XSS using text in the image, which would then get read by OCR. ##### Notable fix: Immich User Agent for external requests Similar to the mobile app, the server now sends a custom [User Agent](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/User-Agent) header. The format for the User Agent is `immich-server/{version}`. For example, `immich-server/2.7.0`. #### `v3.0.0` Just a heads up that this is the likely to be the last release before `v3.0.0`. Being a major release there will be a handful of breaking changes, *although it's worth noting that nothing is currently planned that requires user intervention*. It is mainly changes that impact 3rd party developers. More information and details should be available in the coming weeks. #### Support Immich <p align="center"> <img src="https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExbjY2eWc5Y2F0ZW56MmR4aWE0dDhzZXlidXRmYWZyajl1bWZidXZpcyZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/87CKDqErVfMqY/giphy.gif" width="450" title="SUPPORT THE PROJECT!"> </p> If you find the project helpful, you can support Immich by purchasing a product key at <https://buy.immich.app> or our merchandise at <https://immich.store> ***  #### What's Changed ##### 🚀 Features - feat: add support for helmet configuration by [@jrasm91](https://github.com/jrasm91) in [#27058](immich-app/immich#27058) - feat: create new person in face editor by [@alextran1502](https://github.com/alextran1502) in [#27364](immich-app/immich#27364) ##### 🌟 Enhancements - feat(web): add a seperate tooltip for switching from dark to light mode by [@Vogeluff](https://github.com/Vogeluff) in [#27297](immich-app/immich#27297) - feat(web): focus on face-editor search input by [@cratoo](https://github.com/cratoo) in [#27136](immich-app/immich#27136) - feat(web): add RemoveFromAlbumAction to asset viewer nav bar by [@timonrieger](https://github.com/timonrieger) in [#27000](immich-app/immich#27000) - feat(web): add shortcuts to rotate images by [@squishykid](https://github.com/squishykid) in [#26927](immich-app/immich#26927) - feat(server): add checksum algorithm field by [@etnoy](https://github.com/etnoy) in [#26573](immich-app/immich#26573) - feat(server): resolve duplicates by [@Phlogi](https://github.com/Phlogi) in [#25316](immich-app/immich#25316) - chore(mobile): reduce spacing on video controls by [@uhthomas](https://github.com/uhthomas) in [#27313](immich-app/immich#27313) - perf(server): optimize people page query by [@ffchung](https://github.com/ffchung) in [#27346](immich-app/immich#27346) - feat(web): dim photo outside hovered face bounding box by [@midzelis](https://github.com/midzelis) in [#27402](immich-app/immich#27402) - feat(web): OCR overlay interactivity during zoom by [@midzelis](https://github.com/midzelis) in [#27039](immich-app/immich#27039) - feat: add move to lock folder in folder view by [@alextran1502](https://github.com/alextran1502) in [#27384](immich-app/immich#27384) - feat(web): highlight active person thumbnail in detail panel and edit faces panel by [@midzelis](https://github.com/midzelis) in [#27401](immich-app/immich#27401) - feat: move version checks to our own infrastructure by [@zackpollard](https://github.com/zackpollard) in [#27450](immich-app/immich#27450) - feat: add preview button when selecting images by [@johnmaguire](https://github.com/johnmaguire) in [#27305](immich-app/immich#27305) - fix: user-agent format by [@jrasm91](https://github.com/jrasm91) in [#27488](immich-app/immich#27488) - chore(mobile): reduce buffering timer duration by [@uhthomas](https://github.com/uhthomas) in [#27111](immich-app/immich#27111) - fix(mobile): use key on video controls by [@uhthomas](https://github.com/uhthomas) in [#27512](immich-app/immich#27512) - feat(server): Add support for .ts files by [@ray](https://github.com/ray) in [#27529](immich-app/immich#27529) ##### 🐛 Bug fixes - fix(server): refresh unedited asset dimensions on metadata extraction by [@michelheusschen](https://github.com/michelheusschen) in [#27220](immich-app/immich#27220) - fix(server): memory fragmentation by [@mertalev](https://github.com/mertalev) in [#27027](immich-app/immich#27027) - fix(database restores): don't assume onboarding has completed by [@insertish](https://github.com/insertish) in [#27052](immich-app/immich#27052) - fix(web): preserve timezone when changing timestamp (Closes [#25354](immich-app/immich#25354)) by [@updatemike](https://github.com/updatemike) in [#27095](immich-app/immich#27095) - fix: various command palette usages by [@danieldietzler](https://github.com/danieldietzler) in [#27304](immich-app/immich#27304) - fix(web): keep map view open after closing asset viewer by [@diiogofer](https://github.com/diiogofer) in [#26980](immich-app/immich#26980) - fix(web): prevent Safari from overwriting live photo image with video by [@saurav61091](https://github.com/saurav61091) in [#26898](immich-app/immich#26898) - fix(mobile): video icon not showing on memories by [@YarosMallorca](https://github.com/YarosMallorca) in [#27311](immich-app/immich#27311) - fix(mobile): mismatch between system and app color when using low-chroma system color scheme by [@putuprema](https://github.com/putuprema) in [#27282](immich-app/immich#27282) - fix(mobile): images loads sometimes cancel too early by [@LeLunZ](https://github.com/LeLunZ) in [#27067](immich-app/immich#27067) - fix(mobile): streamline error handling for live photo saving by [@LeLunZ](https://github.com/LeLunZ) in [#27337](immich-app/immich#27337) - fix(web): keep upload totals stable when dismissing items ([#27247](immich-app/immich#27247)) by [@Nicolas-micuda-becker](https://github.com/Nicolas-micuda-becker) in [#27354](immich-app/immich#27354) - fix(mobile): low upload timeout on android by [@mertalev](https://github.com/mertalev) in [#27399](immich-app/immich#27399) - fix(web): add drop shadow to asset viewer nav bar and prevent button shrinking by [@midzelis](https://github.com/midzelis) in [#27404](immich-app/immich#27404) - fix(mobile): favorite button not updating state by [@YarosMallorca](https://github.com/YarosMallorca) in [#27271](immich-app/immich#27271) - fix: detection of WebM container by [@chanb22](https://github.com/chanb22) in [#24182](immich-app/immich#24182) - fix(web): prevent AssetUpdate from adding unrelated timeline assets by [@michelheusschen](https://github.com/michelheusschen) in [#27369](immich-app/immich#27369) - fix: withFilePath select edited or unedited file by [@bwees](https://github.com/bwees) in [#27328](immich-app/immich#27328) - fix(web): Enable stack selector in shared album view by [@timonrieger](https://github.com/timonrieger) in [#24641](immich-app/immich#24641) - fix(server): use substring matching for person name search by [@okxint](https://github.com/okxint) in [#26903](immich-app/immich#26903) - fix: escape html by [@jrasm91](https://github.com/jrasm91) in [#27469](immich-app/immich#27469) - fix(mobile): ignore pointer events on toasts by [@uhthomas](https://github.com/uhthomas) in [#26990](immich-app/immich#26990) - fix(mobile): reset video controls hide timer when showing controls ch… by [@uhthomas](https://github.com/uhthomas) in [#26985](immich-app/immich#26985) - fix(mobile): don't update search filters in-place by [@uhthomas](https://github.com/uhthomas) in [#26965](immich-app/immich#26965) - fix(web): isFullScreen initial value check is incorrect by [@midzelis](https://github.com/midzelis) in [#27520](immich-app/immich#27520) - fix(mobile): transparent system navbar when trash bottom bar is visible by [@putuprema](https://github.com/putuprema) in [#27093](immich-app/immich#27093) - fix: timestamp handling for database backup in Web UI by [@AfonsoMendoncaRibeiro](https://github.com/AfonsoMendoncaRibeiro) in [#27359](immich-app/immich#27359) - fix: allow bots to access /s/ urls by [@domints](https://github.com/domints) in [#27579](immich-app/immich#27579) ##### 📚 Documentation - feat(docs): add keycloack example to oauth docs by [@robson90](https://github.com/robson90) in [#27425](immich-app/immich#27425) ##### 🌐 Translations - chore(web): update translations by [@weblate](https://github.com/weblate) in [#27029](immich-app/immich#27029) - chore(web): update translations by [@weblate](https://github.com/weblate) in [#27483](immich-app/immich#27483) #### New Contributors - [@Vogeluff](https://github.com/Vogeluff) made their first contribution in [#27297](immich-app/immich#27297) - [@updatemike](https://github.com/updatemike) made their first contribution in [#27095](immich-app/immich#27095) - [@diiogofer](https://github.com/diiogofer) made their first contribution in [#26980](immich-app/immich#26980) - [@squishykid](https://github.com/squishykid) made their first contribution in [#26927](immich-app/immich#26927) - [@Phlogi](https://github.com/Phlogi) made their first contribution in [#25316](immich-app/immich#25316) - [@saurav61091](https://github.com/saurav61091) made their first contribution in [#26898](immich-app/immich#26898) - [@putuprema](https://github.com/putuprema) made their first contribution in [#27282](immich-app/immich#27282) - [@ffchung](https://github.com/ffchung) made their first contribution in [#27346](immich-app/immich#27346) - [@chanb22](https://github.com/chanb22) made their first contribution in [#24182](immich-app/immich#24182) - [@robson90](https://github.com/robson90) made their first contribution in [#27425](immich-app/immich#27425) - [@okxint](https://github.com/okxint) made their first contribution in [#26903](immich-app/immich#26903) - [@johnmaguire](https://github.com/johnmaguire) made their first contribution in [#27305](immich-app/immich#27305) - [@ray](https://github.com/ray) made their first contribution in [#27529](immich-app/immich#27529) - [@AfonsoMendoncaRibeiro](https://github.com/AfonsoMendoncaRibeiro) made their first contribution in [#27359](immich-app/immich#27359) - [@domints](https://github.com/domints) made their first contribution in [#27579](immich-app/immich#27579) **Full Changelog**: <immich-app/immich@v2.6.3...v2.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/101 Co-authored-by: bot-owl <bot@erwanleboucher.dev> Co-committed-by: bot-owl <bot@erwanleboucher.dev>

LeLunZ assigned mertalev Mar 20, 2026

LeLunZ requested a review from shenlong-tanwen as a code owner March 20, 2026 00:59

LeLunZ added the 📱mobile label Mar 20, 2026

Copilot AI review requested due to automatic review settings March 20, 2026 00:59

LeLunZ added the changelog:bugfix label Mar 20, 2026

LeLunZ force-pushed the fix/image-loading-hang branch from 01c2b61 to 800666c Compare March 20, 2026 01:00

LeLunZ unassigned mertalev Mar 20, 2026

LeLunZ requested review from mertalev and removed request for Copilot and shenlong-tanwen March 20, 2026 01:01

LeLunZ force-pushed the fix/image-loading-hang branch from 800666c to 5963b5d Compare March 20, 2026 01:07

Copilot AI review requested due to automatic review settings March 20, 2026 01:07

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Comment thread mobile/lib/presentation/widgets/images/cache_aware_listener_tracker.mixin.dart

Comment thread mobile/lib/presentation/widgets/images/cache_aware_listener_tracker.mixin.dart

LeLunZ requested a review from Copilot March 20, 2026 01:25

Copilot started reviewing on behalf of LeLunZ March 20, 2026 01:26 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

mertalev reviewed Mar 20, 2026

View reviewed changes

Comment thread mobile/lib/presentation/widgets/images/cache_aware_listener_tracker.mixin.dart

LeLunZ added 3 commits March 20, 2026 14:52

refactor listener tracking for image stream completers and fix early …

7e76aa7

…cancel call

fix: improve cache listener identification in image stream tracking

6929bf7

add documentation and test cases for listener tracking in ImageStream…

3218238

…Completer

LeLunZ force-pushed the fix/image-loading-hang branch from f32e2f8 to 3218238 Compare March 20, 2026 14:14

mertalev reviewed Mar 20, 2026

View reviewed changes

Comment thread mobile/lib/presentation/widgets/images/cache_aware_listener_tracker.mixin.dart

LeLunZ added 3 commits March 20, 2026 21:18

fix: remove unnecessary image provision flag from listener tracking

1d46b00

fix: override setImage method in cache aware listener tracker mixin

c27f5ca

fix: rename test file

fd29a34

mertalev approved these changes Mar 27, 2026

View reviewed changes

mertalev merged commit 306a3b8 into immich-app:main Mar 27, 2026
44 checks passed

LeLunZ deleted the fix/image-loading-hang branch March 27, 2026 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(mobile): images loads sometimes cancel too early#27067

fix(mobile): images loads sometimes cancel too early#27067
mertalev merged 6 commits intoimmich-app:mainfrom
LeLunZ:fix/image-loading-hang

LeLunZ commented Mar 20, 2026 •

edited

Loading

Uh oh!

uhthomas commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

uhthomas commented Mar 20, 2026

Uh oh!

Uh oh!

LeLunZ commented Mar 20, 2026

Uh oh!

LeLunZ commented Mar 20, 2026 •

edited

Loading

Uh oh!

mertalev left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

LeLunZ commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Please describe to which degree, if any, an LLM was used in creating this pull request.

Uh oh!

uhthomas commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

uhthomas commented Mar 20, 2026

Uh oh!

Uh oh!

LeLunZ commented Mar 20, 2026

Uh oh!

LeLunZ commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mertalev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LeLunZ commented Mar 20, 2026 •

edited

Loading

LeLunZ commented Mar 20, 2026 •

edited

Loading