Merged
Conversation
jrasm91
force-pushed
the
fix/shared-link-add-to-album
branch
from
ee8ffda to
9b25d08
Compare
|
|
||
| private async addToSharedLink(sharedLink: AuthSharedLink, assetId: string) { | ||
| await (sharedLink.albumId | ||
| ? this.albumRepository.addAssetIds(sharedLink.albumId, [assetId]) |
Collaborator
There was a problem hiding this comment.
Duplicate guest uploads to a shared album return an internal server error: PostgresError: duplicate key value violates unique constraint "album_asset_pkey"
Member
Author
There was a problem hiding this comment.
Thanks. I'll update it to ignore conflicts.
4 tasks
danieldietzler
approved these changes
Mar 20, 2026
jrasm91
force-pushed
the
fix/shared-link-add-to-album
branch
from
9b25d08 to
d1203f1
Compare
jrasm91
force-pushed
the
fix/shared-link-add-to-album
branch
from
d1203f1 to
4e31557
Compare
danieldietzler
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #26886, which changed shared link uploads to auto-add assets to the shared link. However, this didn't handle shared link albums. Now, they're also added appropriately depending on the shared link type. There is a migration to remove
shared_link_assetrecords for album shared links. Finally, this removes the necessity to useaddAssetsToAlbumsoraddAssetsToAlbumwith shared link auth, which will be updated in v3 to no longer accept shared link auth.