Skip to content

fix(web): allow pasting PIN code from clipboard or password manager #26944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 3 commits into from
Mar 17, 2026
Merged

fix(web): allow pasting PIN code from clipboard or password manager #26944

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2033c71
fix(web): allow pasting PIN code from clipboard or password manager
Mar 15, 2026
a26ec94
refactor: handle paste in handleInput, remove maxlength
Mar 16, 2026
b5ad7a3
cleanup + fix digit focus
michelheusschen Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions web/src/lib/components/user-settings-page/PinCodeInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,25 +49,22 @@

const handleInput = (event: Event, index: number) => {
const target = event.target as HTMLInputElement;
let currentPinValue = target.value;
const digits = target.value.replaceAll(/\D/g, '').slice(0, pinLength - index);

if (target.value.length > 1) {
currentPinValue = value.slice(0, 1);
}

if (Number.isNaN(Number(value))) {
if (digits.length === 0) {
pinValues[index] = '';
target.value = '';
value = pinValues.join('').trim();
return;
}

pinValues[index] = currentPinValue;
for (let i = 0; i < digits.length; i++) {
pinValues[index + i] = digits[i];
}

value = pinValues.join('').trim();

if (value && index < pinLength - 1) {
focusNext(index);
}
const lastFilledIndex = Math.min(index + digits.length, pinLength - 1);
pinCodeInputElements[lastFilledIndex]?.focus();

if (value.length === pinLength) {
onFilled?.(value);
Expand Down Expand Up @@ -104,12 +101,6 @@
}
return;
}
default: {
if (Number.isNaN(Number(event.key))) {
event.preventDefault();
}
break;
}
}
}
</script>
Expand All @@ -125,7 +116,6 @@
{type}
inputmode="numeric"
pattern="[0-9]*"
maxlength="1"
bind:this={pinCodeInputElements[index]}
id="pin-code-{index}"
class="h-12 w-10 rounded-xl border-2 border-suble dark:border-gray-700 text-center text-lg font-medium focus:border-immich-primary focus:ring-primary dark:focus:border-primary font-mono bg-white dark:bg-light"
Expand Down
Loading