feat: require pull requests to follow template#26902
Merged
alextran1502 merged 2 commits intomainfrom Mar 13, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alextran1502
approved these changes
Mar 13, 2026
1 task
Deeds67
added a commit
to open-noodle/gallery
that referenced
this pull request
Mar 13, 2026
* fix(mobile): inconsistent asset details background (immich-app#26634) The background of the photo view does not extend below the height of the viewport, and so the asset details fade in over black with the photo view, and the standard surface colour scheme of the scaffold for the rest. This leads to a janky animation. We can't change the background of the scaffold to black, as it in turn makes the iOS bouncing scroll physics cut off incorrectly. The best fix is to remove background decoration from the photo view, and defer to the parent to colour the background. Co-authored-by: Alex <alex.tran1502@gmail.com> * fix: playback style migration (immich-app#26718) * feat(mobile): SyncAssetEditV1 (immich-app#26518) * feat(mobile): SyncAssetEditV1 * fix: websocket handling * fix: server version requirement * fix: revert pubspec changes * refactor(web): add --font-sans CSS variable for primary font (immich-app#26730) * feat(web): toggle zoom on double-click in photo viewer (immich-app#26732) * fix(mobile): incorrect asset dimensions in search (immich-app#26725) Search results use a different provider than the main timeline, and they appear appear to have diverged a bit. This means that assets can sometimes look wrong or different in search compared to the main timeline or albums. * fix(web): asset viewer showing wrong viewer type when hovering on stack thumbnails (immich-app#26741) * feat(android): enhance playback style detection using MIME type, reducing glide exposure (immich-app#26747) * feat(android): enhance playback style detection using MIME type * feat(android): improve playback style detection for GIF and WebP formats * fix(android): make playback style detection faster * refactor(android): simplify XMP reading logic for API 29 and below * update playback style detection documentation * use DefaultImageHeaderParser instead of all available ones for webp playbackStyle type detection * fix(mobile): correct local asset dimensions (immich-app#26677) * fix(mobile): correct local asset dimensions We are constraining the size of videos so that they play nicely with hero animations, and don't stretch in weird ways. This however caused a regression as we are not account for local assets on Android which have un-oriented dimensions. * post-orientation width and height in local sync * migration * no need to handle it in asset viewer --------- Co-authored-by: mertalev <101130780+mertalev@users.noreply.github.com> Co-authored-by: Alex <alex.tran1502@gmail.com> * fix(server): opus handling as accepted audio codec in transcode policy (immich-app#26736) * Fix opus handling as accepted audio codec in transcode policy Fix the issue when opus is among accepted audio codecs in transcode policy (which is default) but it still triggers transcoding because the codec name from ffprobe (opus) does not match `libopus` literal in Immich. Make a distinction between a codec name and encoder: - codec name: switch to `opus` as the audio codec name. This matches what ffprobe returns for a media file with opus audio. - encoder: continue using the `libopus` encoder in ffmpeg. * Add unit tests for accepted audio codecs and for libopus encoder * Add db migration for ffmpeg.targetAudioCodec opus * backward compatibility * tweak * noisy logs * full mapping * make check happy * mark deprecated * update api * indexOf --------- Co-authored-by: mertalev <101130780+mertalev@users.noreply.github.com> * feat(ml): enable openvino for cpu (immich-app#22948) * Enable OpenVINO CPU acceleration in Immich * Remove unnecessary debug log * Removing checking for device_ids for openvino since cpu will always be available * Find OpenVINOExecutionProvider index instead of assuming index 0 * Fix openvino tests * Fix failing test mock. OpenVINO expects provider options, but cuda provide doesn't so use that for mocked tests. * Support empty provider options in OrtSessions in which case ONNXRuntime will use its own defaults * Use OpenVINOExecutionProvider for test_sets_provider_options_kwarg * fix mock * simplify * unused variable --------- Co-authored-by: Aleksander <pejcic@adobe.com> Co-authored-by: mertalev <101130780+mertalev@users.noreply.github.com> * feat: responsive video duration in thumbnail (immich-app#26770) * test(e2e): fix flakiness: optimize resetDatabase with TRUNCATE and fix selectDay selector scoping (immich-app#26776) fix(e2e): optimize resetDatabase with TRUNCATE and fix selectDay selector scoping * fix(mobile): restrict trashed asset migration to Android platform (immich-app#26726) * fix(migration): restrict trashed asset migration to Android platform * playbackStyle migration add different log depending on platform * fix(web): refresh recent albums sidebar after album changes (immich-app#26757) * fix(web): show the correct cursor at crop bounds when editing an asset (immich-app#26748) * fix(web): recalculate face bounding boxes (immich-app#26737) Co-authored-by: Daniel Dietzler <mail@ddietzler.dev> * fix(web): context menu overflow (immich-app#26760) * chore: refactor test factories (immich-app#26804) * chore: remove release-pr workflow (immich-app#26742) It's not being used right now; can always add it back :P * fix(web): correct tag rounding in search options (immich-app#26814) * feat(web): animate zoom toggle with cubicOut easing (immich-app#26731) * feat(mobile): consolidate video controls (immich-app#26673) Videos have recently been changed to support zooming, but this can make the controls in the centre of the screen unergonomic as they will either stay in the centre when dismissing, or stick to the video when zooming. Neither is great. We should align the behaviour with other apps which has the play/pause toggle at the bottom of the screen with the seeker bar instead. Co-authored-by: Alex <alex.tran1502@gmail.com> * chore(deps): update docker.io/valkey/valkey:9 docker digest to 3eeb097 (immich-app#26807) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(web): prevent unrelated assets from appearing in tag view (immich-app#26816) * chore(deps): update dependency @types/node to ^24.11.0 (immich-app#26808) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(web): add shortcut "p" to open/close the face tag box (immich-app#26826) * fix(mobile): use tabular figures in backup page (immich-app#26830) The numbers in the backup page are not monospace, and so changes cause the layout to shift. Using tabular figures (monospace) will prevent that. Refs: immich-app#25021 * fix(mobile): wrap backup error message text (immich-app#26834) Refs: immich-app#25022 * feat(mobile): use material design 3 slider (immich-app#26829) * feat(mobile): use material design 3 slider The new slider is easier to use, and looks more modern. * chore: add shadow to button and text for better visibility --------- Co-authored-by: Alex <alex.tran1502@gmail.com> * fix(web): restore asset update events in asset viewer (immich-app#26845) * fix(server): use correct day ordering in timeline buckets (immich-app#26821) * fix(web): sort timeline day groups received from server * fix(server): use correct day ordering in timeline buckets * feat: adaptive progressive image loading for photo viewer (immich-app#26636) * feat(web): adaptive progressive image loading for photo viewer Replace ImageManager with a new AdaptiveImageLoader that progressively loads images through quality tiers (thumbnail → preview → original). New components and utilities: - AdaptiveImage: layered image renderer with thumbhash, thumbnail, preview, and original layers with visibility managed by load state - AdaptiveImageLoader: state machine driving the quality progression with per-quality callbacks and error handling - ImageLayer/Image: low-level image elements with load/error lifecycle - PreloadManager: preloads adjacent assets for instant navigation - AlphaBackground/DelayedLoadingSpinner: loading state UI Zoom is handled via a derived CSS transform applied to the content wrapper in AdaptiveImage, with the zoom library (zoomTarget: null) only tracking state without manipulating the DOM directly. Also adds scaleToCover to container-utils and getAssetUrls to utils. * fix: don't partially render images in firefox * add passive loading indicator to asset-viewer --------- Co-authored-by: Alex <alex.tran1502@gmail.com> * chore: upgrade to kysely 0.28.11 (immich-app#26744) * fix(deps): update typescript-projects (immich-app#26812) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: use pokedex-large runner for rocm (immich-app#26823) * feat(mobile): show animated images in asset viewer (immich-app#26614) * Add support for showing animated images in AssetViewer with AnimatedImageStreamCompleter * Add GIF overlay to thumbnail tile for animated assets * formatting * require isAnimated parameter in image providers for better asset handling * feat: refactor AnimatedImageStreamCompleter to use streams for codec loading and initial image handling * formatting * add isAnimatedImage property to BaseAsset * remove ApiService.getRequestHeaders() usage * fix(mobile): logout on upgrade (immich-app#26827) * use cookiejar * cookie duping hook * remove old pref * handle network switching on logout * remove bootstrapCookies * dead code * fix cast * use constants * use new event name * update api * fix(web): exclude emoji from translation string (immich-app#26852) * fix(server): extract make/model from sony video files (immich-app#26833) Co-authored-by: Your Name <brendan.ngo@okendo.io> Co-authored-by: Daniel Dietzler <mail@ddietzler.dev> * refactor(web): crop area tool (immich-app#26843) * fix(web): face selection box position resetting on browser resize (immich-app#26766) * chore(deps): update dependency exiftool-vendored to v35.13.1 (immich-app#26813) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: more unused release workflow cleanup (immich-app#26817) * chore(mobile): remove background from asset viewer back button (immich-app#26851) We recently changed the asset viewer to use a gradient. The circle button looks out of place now. * chore: add shadow to video play/pause icon shadow (immich-app#26836) * fix(web): fix zoom touch event handling (immich-app#26866) fix(web): fix zoom touch event handling and add clarifying comments - Suppress Safari's synthetic dblclick on double-tap which conflicts with zoom-image's touchstart-based zoom - Add comment explaining pointer-events-none on zoom transform wrapper - Add comments for touchAction and overflow style overrides * refactor: clean class (immich-app#26879) * refactor: external links (immich-app#26880) * refactor: clean class (immich-app#26885) * fix(server): restrict individual shared link asset removal to owners (immich-app#26868) * fix(server): restrict individual shared link asset removal to owners * make open-api * refactor: small test factories (immich-app#26862) * fix: add to shared link (immich-app#26886) * refactor: move encoded video to asset files table (immich-app#26863) * refactor: move encoded video to asset files table * chore: update * fix: use correct original URL for 360 video panorama playback (immich-app#26831) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * fix(web): disable drag and drop for internal items (immich-app#26897) * fix(mobile): video auth (immich-app#26887) * fix video auth * update commit * fix(web): keep header fixed on individual shared links (immich-app#26892) * fix: SMTP over TLS (immich-app#26893) Final step on immich-app#22833 PReq immich-app#22833 is about adding support for SMTP-over-TLS rather than just STARTTLS when sending emails. That PReq adds almost everything; it just forgot to actually pass the flag to Nodemailer at the end. This adds that last line of code and makes it work correctly (for me, anyways!). Co-authored-by: Nathaniel <I@nathaniel.land> * feat: require pull requests to follow template (immich-app#26902) * feat: require pull requests to follow template * fix: persist-credentials: false --------- Co-authored-by: Thomas <9749173+uhthomas@users.noreply.github.com> Co-authored-by: Alex <alex.tran1502@gmail.com> Co-authored-by: Brandon Wees <brandonwees@gmail.com> Co-authored-by: Min Idzelis <min123@gmail.com> Co-authored-by: Snowknight26 <Snowknight26@users.noreply.github.com> Co-authored-by: Luis Nachtigall <31982496+LeLunZ@users.noreply.github.com> Co-authored-by: mertalev <101130780+mertalev@users.noreply.github.com> Co-authored-by: Sergey Katsubo <skatsubo@gmail.com> Co-authored-by: Aleksander Pejcic <apejcic@gmail.com> Co-authored-by: Aleksander <pejcic@adobe.com> Co-authored-by: Michel Heusschen <59014050+michelheusschen@users.noreply.github.com> Co-authored-by: Andreas Heinz <github@a80.net> Co-authored-by: Daniel Dietzler <mail@ddietzler.dev> Co-authored-by: Daniil Suvorov <severecloud@gmail.com> Co-authored-by: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com> Co-authored-by: bo0tzz <git@bo0tzz.me> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Mees Frensel <33722705+meesfrensel@users.noreply.github.com> Co-authored-by: Brendan Ngo <107925883+brendanngo@users.noreply.github.com> Co-authored-by: Your Name <brendan.ngo@okendo.io> Co-authored-by: Jason Rasmussen <jason@rasm.me> Co-authored-by: luis15pt <100942871+luis15pt@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Nathaniel Hourt <nat.hourt@gmail.com> Co-authored-by: Nathaniel <I@nathaniel.land>
brucethomax
pushed a commit
to brucethomax/immich
that referenced
this pull request
Mar 19, 2026
* feat: require pull requests to follow template * fix: persist-credentials: false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ironically, the description of this pull request will not follow the template.
To my understanding the use of $BODY should be safe, but for extra caution I've restricted it to its own job with no permissions.