Skip to content

fix(web): disable drag and drop for internal items #26897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 1 commit into from
Mar 13, 2026
+18 −1
Merged

fix(web): disable drag and drop for internal items #26897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion web/src/lib/components/shared-components/drag-and-drop-upload-overlay.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
let isInLockedFolder = $derived(isLockedFolderRoute(page.route.id));

let dragStartTarget: EventTarget | null = $state(null);
let isInternalDrag = false;

const onDragEnter = (e: DragEvent) => {
if (e.dataTransfer && e.dataTransfer.types.includes('Files')) {
Expand Down Expand Up @@ -133,7 +134,19 @@
}
};

const ondragstart = () => {
isInternalDrag = true;
};

const ondragend = () => {
isInternalDrag = false;
};

const ondragenter = (e: DragEvent) => {
if (isInternalDrag) {
return;
}

e.preventDefault();
e.stopPropagation();
onDragEnter(e);
Expand All @@ -146,6 +159,10 @@
};

const ondrop = async (e: DragEvent) => {
if (isInternalDrag) {
return;
}

e.preventDefault();
e.stopPropagation();
await onDrop(e);
Expand All @@ -159,7 +176,7 @@

<svelte:window onpaste={onPaste} />

<svelte:body {ondragenter} {ondragleave} {ondrop} />
<svelte:body {ondragstart} {ondragend} {ondragenter} {ondragleave} {ondrop} />

{#if dragStartTarget}
<!-- svelte-ignore a11y_no_static_element_interactions -->
Expand Down
Loading