Skip to content

fix(web): Speed up load on data sets that contain thousands of images per day#26877

Closed
ghost wants to merge 8 commits intomainfrom
unknown repository
Closed

fix(web): Speed up load on data sets that contain thousands of images per day#26877
ghost wants to merge 8 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 12, 2026

Description

Fixes #4180

How Has This Been Tested?

Locally tested on a large dataset that contained tens of thousands pictures per day from 2012 to 2026

  • Test A
  • Test B

Screenshots (if appropriate)

been posted in #4180

Checklist:

  • I have carefully read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

None
...

@ghost ghost requested a review from danieldietzler as a code owner March 12, 2026 14:19
@immich-push-o-matic
Copy link

immich-push-o-matic bot commented Mar 12, 2026

Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web. A maintainer will add the required label.

@ghost ghost changed the title Patch 2 Speed up load on data sets that countain thousands of images per day Mar 12, 2026
@ghost
Copy link
Author

ghost commented Mar 12, 2026

related to: #26876

for that pr i don't need a review, for this one however id like you guys to test it out on your local instances

@ghost
Copy link
Author

ghost commented Mar 12, 2026

#4180 (comment)

@ghost
Copy link
Author

ghost commented Mar 12, 2026

video-2026-03-10_16.10.12.mp4

@ghost ghost changed the title Speed up load on data sets that countain thousands of images per day fix: Speed up load on data sets that countain thousands of images per day Mar 12, 2026
@ghost
Copy link
Author

ghost commented Mar 12, 2026

@jrasm91 review as well considering u were involved in original conversation

@ghost ghost changed the title fix: Speed up load on data sets that countain thousands of images per day fix(web): Speed up load on data sets that countain thousands of images per day Mar 12, 2026
@ghost ghost marked this pull request as draft March 12, 2026 16:55
@ghost
Copy link
Author

ghost commented Mar 13, 2026

after merging #26888 this will pass all the tests

@ghost ghost marked this pull request as ready for review March 13, 2026 01:47
@ghost ghost changed the title fix(web): Speed up load on data sets that countain thousands of images per day fix(web): Speed up load on data sets that contain thousands of images per day Mar 13, 2026
@ghost
Copy link
Author

ghost commented Mar 13, 2026

running tests on this is pointless until #26890 is merged

@ghost
Copy link
Author

ghost commented Mar 13, 2026

i just tested without removing heavy states and it seem to work in the similar speed range, 4 (without) vs 6 (with) seconds

image

that's why need review to know what you guys would like to keep in the first place and what can be gone

@ghost
Copy link

ghost commented Mar 16, 2026

will get auto closed soon so if u want to merge this fix, merge it yourself in a separate pr we tried keeping it as simple as possible for a quick merge

Repository owner closed this by deleting the head repository Mar 16, 2026
@immich-app immich-app deleted a comment Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Web client has major performance issues with large image library

1 participant