fix(web): Duplicate Side-by-Side path highlighting fix#26476
Open
qtemp wants to merge 2 commits intoimmich-app:mainfrom
Open
fix(web): Duplicate Side-by-Side path highlighting fix#26476qtemp wants to merge 2 commits intoimmich-app:mainfrom
qtemp wants to merge 2 commits intoimmich-app:mainfrom
Conversation
Change the Duplicate Asset page Side-by-Side view: Changed highlighting for the file path (folder / second line) to only highlight when the file path differs. Changed the tooltip for the file path to only show "File path". Changed the tooltip for the first line, which shows the file name, to show "Full path: " + originalPath.
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web. A maintainer will add the required label. |
Author
|
@alextran1502 I noticed you made the following change #25916 Does my proposed change interfere with that any? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This helps identifying quickly whether the duplicate image is in the same folder or a different folder.
How Has This Been Tested?
Same File Name, Different Path:
Different File Name, Same Path:
Hovering over the file name
Hovering over the file path
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
Claude Connet 4.5 use to identify issue and proposed initial change.