feat(mobile): "Add Tags" asset multiselect option#26269
Open
benjamonnguyen wants to merge 3 commits intoimmich-app:mainfrom
Open
feat(mobile): "Add Tags" asset multiselect option#26269benjamonnguyen wants to merge 3 commits intoimmich-app:mainfrom
benjamonnguyen wants to merge 3 commits intoimmich-app:mainfrom
Conversation
benjamonnguyen
force-pushed
the
push-sllurqlysvqq
branch
from
55da7ca to
b76f707
Compare
benjamonnguyen
force-pushed
the
push-sllurqlysvqq
branch
from
39cc459 to
2ff8ae3
Compare
benjamonnguyen
force-pushed
the
push-sllurqlysvqq
branch
from
2ff8ae3 to
5fd4071
Compare
benjamonnguyen
force-pushed
the
push-sllurqlysvqq
branch
2 times, most recently
from
0aafb6a to
142e66f
Compare
include create tag tile in 'Add Tags' action modal
benjamonnguyen
force-pushed
the
push-sllurqlysvqq
branch
from
142e66f to
c6279f3
Compare
Member
shenlong-tanwen
left a comment
shenlong-tanwen
left a comment
There was a problem hiding this comment.
The control flow in the app is usually UI -> Provider -> Service -> Repository. Can you update the PR to use the same flow as the other parts of the app?
Contributor
Author
Isn't the Notifier serving as the service layer in this case? |
Member
We still use a Service to delegate things because using a notifier as a service would tie the app strictly to riverpod which we plan to avoid so things are easily testable |
benjamonnguyen
force-pushed
the
push-sllurqlysvqq
branch
from
d3d34e2 to
b0f4b2f
Compare
benjamonnguyen
force-pushed
the
push-sllurqlysvqq
branch
from
b0f4b2f to
b20b45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #26196Description
Adds new "Add Tags" multiselect option that allows user to bulk tag assets.
Includes special "create tag tiles" that if selected, creates tags before bulk tagging assets.
How Has This Been Tested?
Manual tests (Android)
Screenshots (if appropriate)
screen-20260216-134923-1771278513265.2.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
...