fix(web): Revert "add checkerboard background for transparent images (#26091)"#26220
fix(web): Revert "add checkerboard background for transparent images (#26091)"#26220alextran1502 merged 1 commit intomainfrom
Conversation
|
@agent-steven FYI, the change from your PR is causing the checkerboard background to render behind all the assets. So I will revert the change for the time being |
|
@alextran1502 is that a problem that it is rendered behind all assets? I think that was the conclusion after I asked how transparent images should be reliably detected without checking mime type? |
|
The problem is the image element is bigger than the actual image content, so the board is showing up all the time. We need to independently fix that problem before we can actually "add it behind the image" |
|
Thx for the explanation :) |
|
@alextran1502 Sorry about that! I should have tested more thoroughly with non-transparent images before submitting. I didn't account for the img element being larger than the rendered content with I've submitted a fix in #26228 — this time the checkerboard is a separate div positioned precisely behind the rendered image area, so it won't bleed into the letterboxed space. Let me know if there are any issues. |
…mmich-app#26091)" (immich-app#26220) Revert "fix(web): add checkerboard background for transparent images (immich-app#26091)" This reverts commit bc7a1c8.
…mmich-app#26091)" (immich-app#26220) Revert "fix(web): add checkerboard background for transparent images (immich-app#26091)" This reverts commit bc7a1c8.
This reverts commit bc7a1c8.