Skip to content

fix(web): Revert "add checkerboard background for transparent images (#26091)"#26220

Merged
alextran1502 merged 1 commit intomainfrom
revert-checker-board
Feb 14, 2026
Merged

fix(web): Revert "add checkerboard background for transparent images (#26091)"#26220
alextran1502 merged 1 commit intomainfrom
revert-checker-board

Conversation

@alextran1502
Copy link
Member

This reverts commit bc7a1c8.

@alextran1502 alextran1502 changed the title Revert "fix(web): add checkerboard background for transparent images (#26091)" fix(web): Revert "add checkerboard background for transparent images (#26091)" Feb 14, 2026
@alextran1502
Copy link
Member Author

@agent-steven FYI, the change from your PR is causing the checkerboard background to render behind all the assets. So I will revert the change for the time being

@alextran1502 alextran1502 enabled auto-merge (squash) February 14, 2026 19:15
@LeLunZ
Copy link
Collaborator

LeLunZ commented Feb 14, 2026

@alextran1502 is that a problem that it is rendered behind all assets?

I think that was the conclusion after I asked how transparent images should be reliably detected without checking mime type?
#26091 (comment)

@jrasm91
Copy link
Member

jrasm91 commented Feb 14, 2026

The problem is the image element is bigger than the actual image content, so the board is showing up all the time. We need to independently fix that problem before we can actually "add it behind the image"

@LeLunZ
Copy link
Collaborator

LeLunZ commented Feb 14, 2026

Thx for the explanation :)

@alextran1502 alextran1502 merged commit 49ba833 into main Feb 14, 2026
64 of 67 checks passed
@alextran1502 alextran1502 deleted the revert-checker-board branch February 14, 2026 20:25
@agent-steven
Copy link
Contributor

@alextran1502 Sorry about that! I should have tested more thoroughly with non-transparent images before submitting. I didn't account for the img element being larger than the rendered content with object-contain.

I've submitted a fix in #26228 — this time the checkerboard is a separate div positioned precisely behind the rendered image area, so it won't bleed into the letterboxed space. Let me know if there are any issues.

kiloomar pushed a commit to kiloomar/immich that referenced this pull request Feb 17, 2026
…mmich-app#26091)" (immich-app#26220)

Revert "fix(web): add checkerboard background for transparent images (immich-app#26091)"

This reverts commit bc7a1c8.
kiloomar pushed a commit to kiloomar/immich that referenced this pull request Feb 17, 2026
…mmich-app#26091)" (immich-app#26220)

Revert "fix(web): add checkerboard background for transparent images (immich-app#26091)"

This reverts commit bc7a1c8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants