-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat(mobile): filter by tags #26196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alextran1502
merged 4 commits into
immich-app:main
from
benjamonnguyen:feat/filter-by-tag
Feb 18, 2026
Merged
feat(mobile): filter by tags #26196
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import 'package:openapi/api.dart'; | ||
|
|
||
| class Tag { | ||
| final String id; | ||
| final String value; | ||
|
|
||
| const Tag({required this.id, required this.value}); | ||
|
|
||
| @override | ||
| String toString() { | ||
| return 'Tag(id: $id, value: $value)'; | ||
| } | ||
|
|
||
| @override | ||
| bool operator ==(covariant Tag other) { | ||
| if (identical(this, other)) return true; | ||
|
|
||
| return other.id == id && other.value == value; | ||
| } | ||
|
|
||
| @override | ||
| int get hashCode { | ||
| return id.hashCode ^ value.hashCode; | ||
| } | ||
|
|
||
| static Tag fromDto(TagResponseDto dto) { | ||
| return Tag(id: dto.id, value: dto.value); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
mobile/lib/infrastructure/repositories/tags_api.repository.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import 'package:hooks_riverpod/hooks_riverpod.dart'; | ||
| import 'package:immich_mobile/infrastructure/repositories/api.repository.dart'; | ||
| import 'package:immich_mobile/providers/api.provider.dart'; | ||
| import 'package:openapi/api.dart'; | ||
|
|
||
| final tagsApiRepositoryProvider = Provider<TagsApiRepository>( | ||
| (ref) => TagsApiRepository(ref.read(apiServiceProvider).tagsApi), | ||
| ); | ||
|
|
||
| class TagsApiRepository extends ApiRepository { | ||
| final TagsApi _api; | ||
| const TagsApiRepository(this._api); | ||
|
|
||
| Future<List<TagResponseDto>?> getAllTags() async { | ||
| return await _api.getAllTags(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamonnguyen marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import 'package:hooks_riverpod/hooks_riverpod.dart'; | ||
| import 'package:immich_mobile/domain/models/tag.model.dart'; | ||
| import 'package:immich_mobile/infrastructure/repositories/tags_api.repository.dart'; | ||
|
|
||
| class TagNotifier extends AsyncNotifier<Set<Tag>> { | ||
shenlong-tanwen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @override | ||
| Future<Set<Tag>> build() async { | ||
| final repo = ref.read(tagsApiRepositoryProvider); | ||
| final allTags = await repo.getAllTags(); | ||
| if (allTags == null) { | ||
| return {}; | ||
| } | ||
| return allTags.map((t) => Tag.fromDto(t)).toSet(); | ||
| } | ||
| } | ||
|
|
||
| final tagProvider = AsyncNotifierProvider<TagNotifier, Set<Tag>>(TagNotifier.new); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:easy_localization/easy_localization.dart'; | ||
| import 'package:flutter_hooks/flutter_hooks.dart'; | ||
| import 'package:hooks_riverpod/hooks_riverpod.dart'; | ||
| import 'package:immich_mobile/domain/models/tag.model.dart'; | ||
| import 'package:immich_mobile/extensions/asyncvalue_extensions.dart'; | ||
| import 'package:immich_mobile/extensions/build_context_extensions.dart'; | ||
| import 'package:immich_mobile/providers/infrastructure/tag.provider.dart'; | ||
| import 'package:immich_mobile/widgets/common/search_field.dart'; | ||
|
|
||
| class TagPicker extends HookConsumerWidget { | ||
| const TagPicker({super.key, required this.onSelect, required this.filter}); | ||
|
|
||
| final Function(Iterable<Tag>) onSelect; | ||
| final Set<String> filter; | ||
|
|
||
| @override | ||
| Widget build(BuildContext context, WidgetRef ref) { | ||
| final formFocus = useFocusNode(); | ||
| final searchQuery = useState(''); | ||
| final tags = ref.watch(tagProvider); | ||
| final selectedTagIds = useState<Set<String>>(filter); | ||
| final borderRadius = const BorderRadius.all(Radius.circular(10)); | ||
|
|
||
| return Column( | ||
| children: [ | ||
| Padding( | ||
| padding: const EdgeInsets.all(8), | ||
| child: SearchField( | ||
| focusNode: formFocus, | ||
| onChanged: (value) => searchQuery.value = value, | ||
| onTapOutside: (_) => formFocus.unfocus(), | ||
| filled: true, | ||
| hintText: 'filter_tags'.tr(), | ||
| ), | ||
| ), | ||
| Padding( | ||
| padding: const EdgeInsets.only(left: 16.0, right: 16.0, bottom: 0), | ||
| child: Divider(color: context.colorScheme.surfaceContainerHighest, thickness: 1), | ||
| ), | ||
| Expanded( | ||
| child: tags.widgetWhen( | ||
| onData: (tags) { | ||
| final queryResult = tags | ||
| .where((t) => t.value.toLowerCase().contains(searchQuery.value.toLowerCase())) | ||
| .toList(); | ||
| return ListView.builder( | ||
| itemCount: queryResult.length, | ||
| padding: const EdgeInsets.all(8), | ||
| itemBuilder: (context, index) { | ||
| final tag = queryResult[index]; | ||
| final isSelected = selectedTagIds.value.any((id) => id == tag.id); | ||
|
|
||
| return Padding( | ||
| padding: const EdgeInsets.only(bottom: 2.0), | ||
| child: Container( | ||
| decoration: BoxDecoration( | ||
| color: isSelected ? context.primaryColor : context.primaryColor.withAlpha(25), | ||
| borderRadius: borderRadius, | ||
| ), | ||
| child: ListTile( | ||
| title: Text( | ||
| tag.value, | ||
| style: context.textTheme.bodyLarge?.copyWith( | ||
| color: isSelected ? context.colorScheme.onPrimary : context.colorScheme.onSurface, | ||
| ), | ||
| ), | ||
| onTap: () { | ||
| final newSelected = {...selectedTagIds.value}; | ||
| if (isSelected) { | ||
| newSelected.removeWhere((id) => id == tag.id); | ||
| } else { | ||
| newSelected.add(tag.id); | ||
| } | ||
| selectedTagIds.value = newSelected; | ||
| onSelect(tags.where((t) => newSelected.contains(t.id))); | ||
| }, | ||
| ), | ||
| ), | ||
| ); | ||
| }, | ||
| ); | ||
| }, | ||
| ), | ||
| ), | ||
| ], | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified this still displays correctly based on user preferences