Skip to content

fix(web): prevent event manager from throwing error #26156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrasm91 merged 1 commit into from
Feb 12, 2026
+2 −2
Merged

fix(web): prevent event manager from throwing error #26156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/lib/utils/base-event-manager.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const nextId = () => count++;
const noop = () => {};

export class BaseEventManager<Events extends EventsBase> {
#callbacks: EventItem<Events>[] = $state([]);
#callbacks: EventItem<Events>[] = $state.raw([]);

on(subscriptions: EventMap<Events>): () => void {
const cleanups = Object.entries(subscriptions).map(([event, callback]) =>
Expand All @@ -36,7 +36,7 @@ export class BaseEventManager<Events extends EventsBase> {

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const item = { id: nextId(), event, callback } as EventItem<Events, any>;
this.#callbacks.push(item);
this.#callbacks = [...this.#callbacks, item];

return () => {
this.#callbacks = this.#callbacks.filter((current) => current.id !== item.id);
Expand Down
Loading