Skip to content

fix: prevent server crash when extraction of metadata fails if the assets are corrupted #26042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrasm91 merged 2 commits into from
Feb 18, 2026
Merged

fix: prevent server crash when extraction of metadata fails if the assets are corrupted #26042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f91de
Fix-25968 Extraction of metadata fails if the assets are corrupted
Devansh-Jani Feb 8, 2026
c18004b
chore: clean up
jrasm91 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion server/src/services/metadata.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ import { isFaceImportEnabled } from 'src/utils/misc';
import { upsertTags } from 'src/utils/tag';
import { Tasks } from 'src/utils/tasks';

const POSTGRES_INT_MAX = 2_147_483_647;
const POSTGRES_INT_MIN = -2_147_483_648;

/** look for a date from these tags (in order) */
const EXIF_DATE_TAGS: Array<keyof ImmichTags> = [
'SubSecDateTimeOriginal',
Expand Down Expand Up @@ -90,7 +93,10 @@ const validate = <T>(value: T): NonNullable<T> | null => {
return null;
}

if (typeof value === 'number' && (Number.isNaN(value) || !Number.isFinite(value))) {
if (
typeof value === 'number' &&
(Number.isNaN(value) || !Number.isFinite(value) || value < POSTGRES_INT_MIN || value > POSTGRES_INT_MAX)
) {
return null;
}

Expand Down
Loading