Skip to content

fix(web): prevent context menu from overflowing viewport #26041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 3 commits into from
Feb 9, 2026
Merged

fix(web): prevent context menu from overflowing viewport #26041

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01b7f0b
fix(web): prevent context menu from overflowing viewport
ttpss930141011 Feb 8, 2026
c091422
fix: linting
jrasm91 Feb 9, 2026
d3cff29
fix: overflow
jrasm91 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions web/src/lib/components/shared-components/context-menu/context-menu.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@

const left = Math.max(8, Math.min(window.innerWidth - rect.width, x - directionWidth));
const top = Math.max(8, Math.min(window.innerHeight - menuHeight, y));
const maxHeight = window.innerHeight - top - 8;

return { left, top };
return { left, top, maxHeight };
});

// We need to bind clientHeight since the bounding box may return a height
Expand Down Expand Up @@ -78,11 +79,8 @@
aria-label={ariaLabel}
aria-labelledby={ariaLabelledBy}
bind:this={menuElement}
class="{isVisible
? 'max-h-dvh'
: 'max-h-0'} flex flex-col transition-all duration-250 ease-in-out outline-none {isTransitioned
? 'overflow-auto'
: ''}"
class="flex flex-col transition-all duration-250 ease-in-out outline-none {isTransitioned ? 'overflow-auto' : ''}"
style:max-height={isVisible ? `${position.maxHeight}px` : '0px'}
role="menu"
tabindex="-1"
>
Expand Down
Loading