Open
Conversation
bwees
force-pushed
the
feat/mobile-editing
branch
from
5bbd7df to
f90d38f
Compare
bwees
force-pushed
the
feat/mobile-editing
branch
5 times, most recently
from
374df90 to
b366c8c
Compare
bwees
force-pushed
the
feat/mobile-editing
branch
7 times, most recently
from
ec03a1a to
7f857ab
Compare
bwees
requested review from
danieldietzler and
shenlong-tanwen
as code owners
bwees
force-pushed
the
feat/mobile-editing
branch
3 times, most recently
from
5f9167c to
ef4e339
Compare
mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart
Outdated
Show resolved
Hide resolved
jrasm91
requested changes
Feb 19, 2026
jrasm91
reviewed
Feb 19, 2026
Comment on lines
+564
to
+565
| "asset_edit_failed": "Asset edit failed", | ||
| "asset_edit_success": "Asset edited successfully", |
Member
There was a problem hiding this comment.
Can we just use Success and Something went wrong instead? I don't think these messages really provide much benefit and it means they are two more strings that have to be translated to every language.
Member
Author
There was a problem hiding this comment.
Yeah thats probably a good idea
bwees
force-pushed
the
feat/mobile-editing
branch
3 times, most recently
from
72586b3 to
2b1a133
Compare
4 tasks
bwees
force-pushed
the
feat/mobile-editing
branch
from
2b1a133 to
a52be3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for the new editing system on mobile
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
...