Skip to content

fix: description does not rerender when navigating between assets #25137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 1 commit into from
Jan 8, 2026
Merged

fix: description does not rerender when navigating between assets #25137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions web/src/lib/components/asset-viewer/detail-panel-description.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,16 @@

let { asset, isOwner }: Props = $props();

let currentDescription = asset.exifInfo?.description ?? '';
let draftDescription = $state(currentDescription);
let currentDescription = $derived(asset.exifInfo?.description ?? '');
let description = $derived(currentDescription);

const handleFocusOut = async () => {
if (draftDescription === currentDescription) {
if (description === currentDescription) {
return;
}
try {
await updateAsset({ id: asset.id, updateAssetDto: { description: draftDescription } });
await updateAsset({ id: asset.id, updateAssetDto: { description } });
toastManager.success($t('asset_description_updated'));
currentDescription = draftDescription;
} catch (error) {
handleError(error, $t('cannot_update_the_description'));
}
Expand All @@ -33,7 +32,7 @@
{#if isOwner}
<section class="px-4 mt-10">
<Textarea
bind:value={draftDescription}
bind:value={description}
class="max-h-40 outline-none border-b border-gray-500 bg-transparent ring-0 focus:ring-0 resize-none focus:border-b-2 focus:border-immich-primary dark:focus:border-immich-dark-primary dark:bg-transparent"
rows={1}
grow
Expand All @@ -47,8 +46,8 @@
}))}
/>
</section>
{:else if draftDescription}
{:else if description}
<section class="px-4 mt-6">
<p class="wrap-break-word whitespace-pre-line w-full text-black dark:text-white text-base">{draftDescription}</p>
<p class="wrap-break-word whitespace-pre-line w-full text-black dark:text-white text-base">{description}</p>
</section>
{/if}
Loading