Skip to content

fix: search input has incorrect focus state after closing the search filter modal #24886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldietzler merged 1 commit into from
Jan 5, 2026
Merged

fix: search input has incorrect focus state after closing the search filter modal #24886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions web/src/lib/components/shared-components/search-bar/search-bar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
if (close) {
await close();
close = undefined;
searchStore.isSearchEnabled = false;
return;
}

Expand All @@ -120,6 +121,7 @@

const searchResult = await result.onClose;
close = undefined;
searchStore.isSearchEnabled = false;

// Refresh search type after modal closes
getSearchType();
Expand Down Expand Up @@ -346,18 +348,6 @@
</div>
{/if}

<div class="absolute inset-y-0 {showClearIcon ? 'end-14' : 'end-2'} flex items-center ps-6 transition-all">
<IconButton
aria-label={$t('show_search_options')}
shape="round"
icon={mdiTune}
onclick={onFilterClick}
size="medium"
color="secondary"
variant="ghost"
/>
</div>

{#if showClearIcon}
<div class="absolute inset-y-0 end-0 flex items-center pe-2">
<IconButton
Expand All @@ -384,4 +374,16 @@
/>
</div>
</form>

<div class="absolute inset-y-0 {showClearIcon ? 'end-14' : 'end-2'} flex items-center ps-6 transition-all">
<IconButton
aria-label={$t('show_search_options')}
shape="round"
icon={mdiTune}
onclick={onFilterClick}
size="medium"
color="secondary"
variant="ghost"
/>
</div>
</div>
Loading