fix(mobile): Timeline grid not resizing properly on device rotation by timonrieger · Pull Request #24573 · immich-app/immich

timonrieger · 2025-12-14T13:32:24Z

Tries to fix #24446

This is not trivial, unfortunately. Pixel-based preservation fails because tile dimensions change on rotation (portrait vs landscape have different tile heights), causing the same pixel offset to map to different visual content.

EDIT: i got it working, thanks to @kao-byte in #24573 (comment) 🎉

Description

The timeline now correctly resizes the layout when rotating the device. The scroll position is being restored when rotating the device, similar to how the old timeline handles scroll position.

Most of the implementation got bridged from the old timeline, where this issue was a not present.

Fixes #24446
Fixes #22540

How Has This Been Tested?

Rotate device while scrolling timeline - scroll position is preserved and timeline resizes to the screen width

Screenshots

demo-24573.mov

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation if applicable
I have no unrelated changes in the PR.
I have confirmed that any new dependencies are strictly necessary.
I have written tests for new code (if applicable)
I have followed naming conventions/patterns in the surrounding code
All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

LLM assistance was used to bridge the anchor logic from the old timeline to the new one.

immich-push-o-matic · 2025-12-14T13:32:34Z

Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile. A maintainer will add the required label.

kao-byte · 2025-12-17T13:16:36Z

Perhaps you can gain some ideas from the old timeline; this issue wasn’t present there.

timonrieger · 2025-12-17T14:35:35Z

Perhaps you can gain some ideas from the old timeline; this issue wasn’t present there.

Do you now until which version the old timeline was in-place?

kao-byte · 2025-12-17T14:52:32Z

Perhaps you can gain some ideas from the old timeline; this issue wasn’t present there.

Do you now until which version the old timeline was in-place?

@timonrieger The latest version should still include the old timeline codes as you can disable the new timeline via Settings -> Advanced.

timonrieger · 2025-12-17T14:55:21Z

Perhaps you can gain some ideas from the old timeline; this issue wasn’t present there.

Do you now until which version the old timeline was in-place?

@timonrieger The latest version should still include the old timeline codes as you can disable the new timeline via Settings -> Advanced.

true that, thanks for the bump 😄

timonrieger · 2025-12-17T16:19:13Z

mobile/lib/presentation/widgets/timeline/fixed/segment_builder.dart

+        startOffset += headerExtent + spacing + (tileHeight * numberOfRows) + spacing * (numberOfRows - 1);
+      } else {
+        startOffset += headerExtent;
+      }


self-review: When numberOfRows == 0, there are no asset rows, so we only add the header extent and skip spacing/tile heights that don't apply.

timonrieger · 2025-12-17T16:25:38Z

mobile/lib/presentation/widgets/memory/memory_lane.widget.dart

-            DriftMemoryPage.setMemory(ref, memories[index]);
-          }
-          context.pushRoute(DriftMemoryRoute(memories: memories, memoryIndex: index));
+      child: ListView.separated(


self-review: CarouselView triggered a framework assertion during rotation ('haveDimensions == (_lastMetrics != null)')

A ListView is different from CarouselView. We should be fixing the issue and not replace it with a different widget

Implement continuous row anchor tracking and automatic scroll adjustment when segments change, matching web timeline behavior. This ensures stable scroll position during orientation changes by using (rowIndex, deltaPx) anchors instead of unreliable pixel offsets. - Add _onScroll() listener to continuously update row anchor - Auto-adjust scroll when segments regenerate (width/columnCount change) - Remove pixel-based fallback restoration logic

timonrieger · 2026-01-13T18:38:16Z

a merge conflict introduced by #24999 must be resolved, don't know if that addition was intentional there

alextran1502 · 2026-01-16T00:59:04Z

@shenlong-tanwen Can you help with reviewing this PR? Thank you

shenlong-tanwen · 2026-01-19T16:00:16Z

mobile/lib/presentation/widgets/memory/memory_lane.widget.dart

-            DriftMemoryPage.setMemory(ref, memories[index]);
-          }
-          context.pushRoute(DriftMemoryRoute(memories: memories, memoryIndex: index));
+      child: ListView.separated(


A ListView is different from CarouselView. We should be fixing the issue and not replace it with a different widget

shenlong-tanwen · 2026-01-19T16:01:51Z

mobile/lib/presentation/widgets/timeline/fixed/segment_builder.dart

      final segmentStartOffset = startOffset;
-      startOffset += headerExtent + (tileHeight * numberOfRows) + spacing * (numberOfRows - 1);
+      if (numberOfRows > 0) {
+        startOffset += headerExtent + spacing + (tileHeight * numberOfRows) + spacing * (numberOfRows - 1);


Was the duplicate spacing intentional?

Suggested change

startOffset += headerExtent + spacing + (tileHeight * numberOfRows) + spacing * (numberOfRows - 1);

startOffset += headerExtent + (tileHeight * numberOfRows) + spacing * (numberOfRows - 1);

shenlong-tanwen · 2026-01-19T16:06:28Z

mobile/lib/presentation/widgets/timeline/timeline.widget.dart

+            child: Consumer(
+              builder: (context, ref, _) {
+                final columnCount = ref.watch(settingsProvider.select((s) => s.get(Setting.tilesPerRow)));
+                final desired = TimelineArgs(
+                  maxWidth: constraints.maxWidth,
+                  maxHeight: constraints.maxHeight,
+                  columnCount: columnCount,
+                  showStorageIndicator: showStorageIndicator,
+                  withStack: withStack,
+                  groupBy: groupBy,
+                );
+                final current = ref.watch(_runtimeTimelineArgsProvider);
+
+                if (current != desired) {
+                  final rowAnchor = ref.read(_timelineAnchorRowProvider);
+                  WidgetsBinding.instance.addPostFrameCallback((_) {
+                    final latest = ref.read(_runtimeTimelineArgsProvider);
+                    if (latest != desired) {
+                      ref.read(_runtimeTimelineArgsProvider.notifier).state = desired;
+                    }
+                    if (rowAnchor != null) {
+                      ref.read(_timelinePendingRestoreRowAnchorProvider.notifier).state = rowAnchor;
+                    }
+                  });
+                }


Why'd we need all these complex rebuild flows? All we need to do is to rebuild the widget on orientation state while retaining the anchor. It should actually be possible with just a single provider that stores the required anchor before rebuild and restores it after the change. Can you look into simplifying all the provider logic? Or can you explain why we need each of the providers?

timonrieger · 2026-01-21T14:57:23Z

closing this in favor of #25088 as discussed

immich-push-o-matic bot added the 📱mobile label Dec 14, 2025

timonrieger marked this pull request as ready for review December 17, 2025 16:16

timonrieger requested a review from shenlong-tanwen as a code owner December 17, 2025 16:16

timonrieger commented Dec 17, 2025

View reviewed changes

timonrieger added 11 commits December 17, 2025 17:27

first try

abe1ab0

second try

8f80f20

remove debug logs

7993848

lint and format

c2add9e

remove stale test

cf3d7ae

remove debug comments

126e8b1

remove another debug section

ad9a604

remove unused code block

e7baf44

remove whitespace

4343a76

remove comment

b1ea976

timonrieger force-pushed the expand-landscape-grid-view branch from 6ca4969 to b1ea976 Compare December 17, 2025 16:27

Merge branch 'main' into expand-landscape-grid-view

d2686f6

shenlong-tanwen mentioned this pull request Jan 19, 2026

fix(mobile): photo grid reflows on foldable display fold/unfold #24529

Closed

4 tasks

shenlong-tanwen reviewed Jan 19, 2026

View reviewed changes

timonrieger closed this Jan 21, 2026

timonrieger deleted the expand-landscape-grid-view branch January 28, 2026 15:07

timonrieger mentioned this pull request Jan 28, 2026

fix(mobile): timeline handling on foldable phones + ensuring that images are not cut off #25088

Merged

8 tasks

	startOffset += headerExtent + spacing + (tileHeight * numberOfRows) + spacing * (numberOfRows - 1);
	startOffset += headerExtent + (tileHeight * numberOfRows) + spacing * (numberOfRows - 1);

Uh oh!

Conversation

timonrieger commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Screenshots

Checklist:

Please describe to which degree, if any, an LLM was used in creating this pull request.

Uh oh!

immich-push-o-matic bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kao-byte commented Dec 17, 2025

Uh oh!

timonrieger commented Dec 17, 2025

Uh oh!

kao-byte commented Dec 17, 2025

Uh oh!

timonrieger commented Dec 17, 2025

Uh oh!

timonrieger Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

timonrieger Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shenlong-tanwen Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

timonrieger commented Jan 13, 2026

Uh oh!

alextran1502 commented Jan 16, 2026

Uh oh!

shenlong-tanwen Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

shenlong-tanwen Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

shenlong-tanwen Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

timonrieger commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

timonrieger commented Dec 14, 2025 •

edited

Loading

immich-push-o-matic bot commented Dec 14, 2025 •

edited

Loading

timonrieger Dec 17, 2025 •

edited

Loading