Skip to content

fix(mobile): buttons inside AddActionButton color is the same as background color#24460

Merged
alextran1502 merged 2 commits intomainfrom
fix/add-to-button
Dec 8, 2025
Merged

fix(mobile): buttons inside AddActionButton color is the same as background color#24460
alextran1502 merged 2 commits intomainfrom
fix/add-to-button

Conversation

@idubnori
Copy link
Copy Markdown
Collaborator

@idubnori idubnori commented Dec 8, 2025

Description

How Has This Been Tested?

Manual visual testing on iOS Simulator

  • Automatic theme
  • Dark mode

Screenshots (if appropriate)

Before After(default theme) After(dark mode)
iPhone_16 iPhone_16e iPhone_16e1

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

initial implementation

const AddActionButton({super.key});
const AddActionButton({super.key, this.originalTheme});

final ThemeData? originalTheme;
Copy link
Copy Markdown
Collaborator Author

@idubnori idubnori Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ThemeData is optional: e.g. in reordering feature, original theme is no needed #23635

@idubnori idubnori marked this pull request as ready for review December 8, 2025 15:50
@idubnori idubnori requested a review from alextran1502 December 8, 2025 15:50
@alextran1502 alextran1502 merged commit 287f6d5 into main Dec 8, 2025
60 of 62 checks passed
@alextran1502 alextran1502 deleted the fix/add-to-button branch December 8, 2025 20:29
@idubnori idubnori mentioned this pull request Dec 8, 2025
8 tasks
lwbio pushed a commit to lwbio/immich that referenced this pull request Dec 16, 2025
…ground color (immich-app#24460)

* fix: icon & text color in AddActionButton

* fix: use Divider
kiloomar pushed a commit to kiloomar/immich that referenced this pull request Jan 12, 2026
…ground color (immich-app#24460)

* fix: icon & text color in AddActionButton

* fix: use Divider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants