Closed
Conversation
alextran1502
force-pushed
the
prevent-soft-freeze
branch
2 times, most recently
from
dfbe5e6 to
6f04282
Compare
alextran1502
force-pushed
the
prevent-soft-freeze
branch
from
6f04282 to
82b7b8a
Compare
Comment on lines
+64
to
+68
| // ignore: unused_field | ||
| final Isar _isar; | ||
| // ignore: unused_field | ||
| final Drift _drift; | ||
| // ignore: unused_field |
Member
There was a problem hiding this comment.
We can remove them from the class if they're not used anymore. Just pass them to the constructor to build the ProviderContainer and not store them locally
Member
Author
|
Fixed in #23877 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where cleaning up database in the background can cause database inaccessible when open the app on the foreground