Skip to content

fix: clear temp cache on iOS before uploads #23326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 1 commit into from
Oct 28, 2025
Merged

fix: clear temp cache on iOS before uploads #23326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mobile/lib/infrastructure/repositories/storage.repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:io';

import 'package:immich_mobile/domain/models/asset/base_asset.model.dart';
import 'package:immich_mobile/extensions/platform_extensions.dart';
import 'package:logging/logging.dart';
import 'package:photo_manager/photo_manager.dart';

Expand Down Expand Up @@ -89,5 +90,17 @@ class StorageRepository {
} catch (error, stackTrace) {
log.warning("Error clearing cache", error, stackTrace);
}

if (!CurrentPlatform.isIOS) {
return;
}

try {
if (await Directory.systemTemp.exists()) {
await Directory.systemTemp.delete(recursive: true);
Copy link
Member

@mertalev mertalev Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a bit excessive to delete everything in system temp? That includes things unrelated to Immich, doesn't it?

Copy link
Member Author

@shenlong-tanwen shenlong-tanwen Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On iOS / macOS, the directory is actually internal to the App's sandbox even though the static accessor says systemTemp

}
} catch (error, stackTrace) {
log.warning("Error deleting temporary directory", error, stackTrace);
}
}
}
Loading