Skip to content

fix(web): prevent photo-only memories showing mute button#22802

Merged
danieldietzler merged 1 commit intoimmich-app:mainfrom
meesfrensel:fix/memories-mute-button
Oct 15, 2025
Merged

fix(web): prevent photo-only memories showing mute button#22802
danieldietzler merged 1 commit intoimmich-app:mainfrom
meesfrensel:fix/memories-mute-button

Conversation

@meesfrensel
Copy link
Collaborator

Description

Currently, the mute button in the memories slideshow is always shown. This doesn't make sense when there aren't any videos. This commit changes the mute button to be only visible if a memory contains at least one video. Other memories aren't taken in consideration; if the current memory is photo-only, the mute button is hidden, and it reappears when viewing the next memory (that contains a video).

Fixes #21355

How Has This Been Tested?

Not sure how to test this, except manually

  • Upload photos of today, 2 years ago. Upload at least one video and if you want, photos, dated today, 1 year ago. Regenerate memories (can be tricky) and verify the mute button is hidden on the 2 years ago memory, and shown on the 1 year ago memory.

Screenshots

with mute button, as memory contains video
image

without mute button, as memory contains only photos
image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

None

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mute button displayed for all media types in Memories

2 participants