-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat(mobile): display error on app init fail #22758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
denysvitali
wants to merge
3
commits into
immich-app:main
from
denysvitali:feature/display-error-on-app-init-fail
+242
−20
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,203 @@ | ||
| import 'dart:io'; | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter/services.dart'; | ||
| import 'package:package_info_plus/package_info_plus.dart'; | ||
|
|
||
| class ErrorDisplayScreen extends StatelessWidget { | ||
| final String error; | ||
| final String stackTrace; | ||
|
|
||
| const ErrorDisplayScreen({ | ||
| super.key, | ||
| required this.error, | ||
| required this.stackTrace, | ||
| }); | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final theme = Theme.of(context); | ||
|
|
||
| return Scaffold( | ||
| body: Center( | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(24.0), | ||
| child: Column( | ||
| mainAxisAlignment: MainAxisAlignment.center, | ||
| children: [ | ||
| // App logo with error indicator | ||
| Stack( | ||
| children: [ | ||
| Image.asset( | ||
| 'assets/immich-logo.png', | ||
| width: 80, | ||
| height: 80, | ||
| ), | ||
| Positioned( | ||
| bottom: 0, | ||
| right: 0, | ||
| child: Container( | ||
| width: 24, | ||
| height: 24, | ||
| decoration: BoxDecoration( | ||
| color: theme.colorScheme.error, | ||
| shape: BoxShape.circle, | ||
| ), | ||
| child: Icon( | ||
| Icons.error, | ||
| color: theme.colorScheme.onError, | ||
| size: 16, | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| const SizedBox(height: 24), | ||
|
|
||
| // Error title | ||
| Text( | ||
| 'Initialization Failed', | ||
| style: TextStyle( | ||
| fontSize: 28, | ||
| fontWeight: FontWeight.bold, | ||
| color: theme.colorScheme.onSurface, | ||
| ), | ||
| textAlign: TextAlign.center, | ||
| ), | ||
| const SizedBox(height: 16), | ||
|
|
||
| // Error message | ||
| Text( | ||
| 'Failed to start due to an error during initialization.', | ||
| style: TextStyle( | ||
| color: theme.colorScheme.onSurfaceVariant, | ||
| fontSize: 16, | ||
| ), | ||
| textAlign: TextAlign.center, | ||
| ), | ||
| const SizedBox(height: 24), | ||
|
|
||
| // Expandable error details | ||
| Container( | ||
| width: double.infinity, | ||
| padding: const EdgeInsets.all(16), | ||
| decoration: BoxDecoration( | ||
| color: theme.colorScheme.surfaceContainer, | ||
| borderRadius: BorderRadius.circular(12), | ||
| border: Border.all(color: theme.colorScheme.error), | ||
| ), | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| Row( | ||
| mainAxisAlignment: MainAxisAlignment.spaceBetween, | ||
| children: [ | ||
| Text( | ||
| 'Error Details:', | ||
| style: TextStyle( | ||
| color: theme.colorScheme.error, | ||
| fontSize: 14, | ||
| fontWeight: FontWeight.bold, | ||
| ), | ||
| ), | ||
| IconButton( | ||
| onPressed: () async { | ||
| String errorDetails; | ||
| try { | ||
| final packageInfo = await PackageInfo.fromPlatform(); | ||
| final appVersion = '${packageInfo.version} build.${packageInfo.buildNumber}'; | ||
| errorDetails = 'App Version: $appVersion\n\nError: $error\n\nStack Trace:\n$stackTrace'; | ||
| } catch (e) { | ||
| // Fallback if package info fails | ||
| errorDetails = 'Error: $error\n\nStack Trace:\n$stackTrace'; | ||
| } | ||
|
|
||
| Clipboard.setData(ClipboardData(text: errorDetails)).then((_) { | ||
| ScaffoldMessenger.of(context).showSnackBar( | ||
| SnackBar( | ||
| content: const Text('Error details copied to clipboard'), | ||
| backgroundColor: theme.colorScheme.primary, | ||
| ), | ||
| ); | ||
| }); | ||
| }, | ||
| icon: Icon( | ||
| Icons.copy, | ||
| color: theme.colorScheme.onSurfaceVariant, | ||
| size: 18, | ||
| ), | ||
| padding: EdgeInsets.zero, | ||
| constraints: const BoxConstraints(), | ||
| ), | ||
| ], | ||
| ), | ||
| const SizedBox(height: 8), | ||
| Text( | ||
| error, | ||
| style: TextStyle( | ||
| color: theme.colorScheme.onSurface, | ||
| fontSize: 12, | ||
| fontFamily: 'monospace', | ||
| ), | ||
| ), | ||
| const SizedBox(height: 16), | ||
| ExpansionTile( | ||
| title: Text( | ||
| 'Stack Trace', | ||
| style: TextStyle( | ||
| color: theme.colorScheme.tertiary, | ||
| fontSize: 12, | ||
| ), | ||
| ), | ||
| tilePadding: EdgeInsets.zero, | ||
| iconColor: theme.colorScheme.onSurfaceVariant, | ||
| collapsedIconColor: theme.colorScheme.onSurfaceVariant, | ||
| children: [ | ||
| Container( | ||
| width: double.infinity, | ||
| padding: const EdgeInsets.all(8), | ||
| decoration: BoxDecoration( | ||
| color: theme.colorScheme.surfaceContainerHighest, | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| child: SingleChildScrollView( | ||
| child: Text( | ||
| stackTrace, | ||
| style: TextStyle( | ||
| color: theme.colorScheme.onSurface, | ||
| fontSize: 10, | ||
| fontFamily: 'monospace', | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| const SizedBox(height: 24), | ||
|
|
||
| // Restart button | ||
| ElevatedButton.icon( | ||
| onPressed: () { | ||
| // Attempt to restart the app | ||
| if (Platform.isAndroid || Platform.isIOS) { | ||
| exit(0); | ||
| } | ||
| }, | ||
| icon: const Icon(Icons.close), | ||
| label: const Text('Close App'), | ||
| style: ElevatedButton.styleFrom( | ||
| backgroundColor: theme.colorScheme.error, | ||
| foregroundColor: theme.colorScheme.onError, | ||
| padding: const EdgeInsets.symmetric(horizontal: 24, vertical: 12), | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
|
Comment on lines
+181
to
+198
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's not have a restart button. Apple recommends against calling exit programatically Can you also fix the failing static analysis? |
||
| ), | ||
| ), | ||
| ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an
ImmichLogowidget available