Skip to content

fix(server): fix chunking Postgres query parameters #22684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mertalev merged 3 commits into from
Oct 6, 2025
Merged

fix(server): fix chunking Postgres query parameters #22684

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69937f1
Fix undefined result of processing a chunk
skatsubo Oct 5, 2025
d26ec58
Fix merging result sets by spreading them into setUnion instead of pa…
skatsubo Oct 5, 2025
fcbf838
Make linter happy
skatsubo Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/src/decorators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export function Chunked(

return Promise.all(
chunks(argument, chunkSize).map(async (chunk) => {
await Reflect.apply(originalMethod, this, [
return await Reflect.apply(originalMethod, this, [
...arguments_.slice(0, parameterIndex),
chunk,
...arguments_.slice(parameterIndex + 1),
Expand All @@ -103,7 +103,7 @@ export function ChunkedArray(options?: { paramIndex?: number }): MethodDecorator
}

export function ChunkedSet(options?: { paramIndex?: number }): MethodDecorator {
return Chunked({ ...options, mergeFn: setUnion });
return Chunked({ ...options, mergeFn: (args: Set<any>[]) => setUnion(...args) });
}

const UUID = '00000000-0000-4000-a000-000000000000';
Expand Down
Loading