Skip to content

fix: respect storage indicator setting #22596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 3 commits into from
Oct 3, 2025
Merged

fix: respect storage indicator setting #22596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be0006f
fix: respect storage indicator size setting
shenlong-tanwen Oct 2, 2025
aaabe3a
Merge branch 'main' of github.com:immich-app/immich into fix/indicator
alextran1502 Oct 3, 2025
c0150e0
remove black bar on the bottom of the setting scaffold page
alextran1502 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions mobile/lib/pages/common/settings.page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,9 @@ class SettingsSubPage extends StatelessWidget {
@override
Widget build(BuildContext context) {
context.locale;
return SafeArea(
bottom: true,
top: false,
right: true,
child: Scaffold(
appBar: AppBar(centerTitle: false, title: Text(section.title).tr()),
body: section.widget,
),
return Scaffold(
appBar: AppBar(centerTitle: false, title: Text(section.title).tr()),
body: section.widget,
);
}
}
6 changes: 3 additions & 3 deletions mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class ThumbnailTile extends ConsumerWidget {
this.asset, {
this.size = kThumbnailResolution,
this.fit = BoxFit.cover,
this.showStorageIndicator,
this.showStorageIndicator = false,
this.lockSelection = false,
this.heroOffset,
super.key,
Expand All @@ -25,7 +25,7 @@ class ThumbnailTile extends ConsumerWidget {
final BaseAsset? asset;
final Size size;
final BoxFit fit;
final bool? showStorageIndicator;
final bool showStorageIndicator;
final bool lockSelection;
final int? heroOffset;

Expand Down Expand Up @@ -55,7 +55,7 @@ class ThumbnailTile extends ConsumerWidget {
: const BoxDecoration();

final bool storageIndicator =
showStorageIndicator ?? ref.watch(settingsProvider.select((s) => s.get(Setting.showStorageIndicator)));
ref.watch(settingsProvider.select((s) => s.get(Setting.showStorageIndicator))) && showStorageIndicator;

return Stack(
children: [
Expand Down
4 changes: 2 additions & 2 deletions mobile/lib/presentation/widgets/timeline/timeline.state.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TimelineArgs {
final double maxHeight;
final double spacing;
final int columnCount;
final bool? showStorageIndicator;
final bool showStorageIndicator;
final bool withStack;
final GroupAssetsBy? groupBy;

Expand All @@ -23,7 +23,7 @@ class TimelineArgs {
required this.maxHeight,
this.spacing = kTimelineSpacing,
this.columnCount = kTimelineColumnCount,
this.showStorageIndicator,
this.showStorageIndicator = false,
this.withStack = false,
this.groupBy,
});
Expand Down
Loading