Skip to content

feat(web): reactively update shared link expiration #22274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldietzler merged 3 commits into from
Oct 24, 2025
Merged

feat(web): reactively update shared link expiration #22274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aab255
fix(web): update shared link expiration in UI without full refresh
google-labs-jules[bot] Sep 21, 2025
c6db1fe
Merge pull request #1 from khanbasharat3a1/fix-shared-link-expiration…
khanbasharat3a1 Sep 21, 2025
9d62c8b
Merge branch 'main' into main
khanbasharat3a1 Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/lib/modals/SharedLinkCreateModal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
try {
const expirationDate = expirationOption > 0 ? DateTime.now().plus(expirationOption).toISO() : null;

await updateSharedLink({
const updatedLink = await updateSharedLink({
id: editingLink.id,
sharedLinkEditDto: {
description,
Expand All @@ -121,7 +121,7 @@
message: $t('edited'),
});

onClose();
onClose(updatedLink);
} catch (error) {
handleError(error, $t('errors.failed_to_edit_shared_link'));
}
Expand Down
11 changes: 9 additions & 2 deletions web/src/routes/(user)/shared-links/[[id=id]]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,15 @@
}
};

const handleEditDone = async () => {
await refresh();
const handleEditDone = async (updatedLink?: SharedLinkResponseDto) => {
if (updatedLink) {
const index = sharedLinks.findIndex((link) => link.id === updatedLink.id);
if (index !== -1) {
sharedLinks[index] = updatedLink;
}
} else {
await refresh();
}
await goto(AppRoute.SHARED_LINKS);
};

Expand Down
Loading