Skip to content

fix(mobile): video player using ref after disposal #21843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mertalev merged 2 commits into from
Oct 6, 2025
Merged

fix(mobile): video player using ref after disposal #21843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75c0f58
check if disposed
mertalev Sep 11, 2025
2c7d853
Merge branch 'main' into fix/mobile-video-player-ref
mertalev Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mobile/lib/presentation/widgets/asset_viewer/video_viewer.widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,18 @@ class NativeVideoViewer extends HookConsumerWidget {
}

final videoAsset = await ref.read(assetServiceProvider).getAsset(asset) ?? asset;
if (!context.mounted) {
return null;
}

try {
if (videoAsset.hasLocal && videoAsset.livePhotoVideoId == null) {
final id = videoAsset is LocalAsset ? videoAsset.id : (videoAsset as RemoteAsset).localId!;
final file = await const StorageRepository().getFileForAsset(id);
if (!context.mounted) {
return null;
}

if (file == null) {
throw Exception('No file found for the video');
}
Expand Down Expand Up @@ -289,7 +297,7 @@ class NativeVideoViewer extends HookConsumerWidget {
ref.read(videoPlaybackValueProvider.notifier).reset();

final source = await videoSource;
if (source == null) {
if (source == null || !context.mounted) {
return;
}

Expand Down
Loading