Skip to content

fix: keyboard not dismissed in places page #21583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

fix: keyboard not dismissed in places page #21583

merged 1 commit into from
Sep 4, 2025

Conversation

shenlong-tanwen
Copy link
Member

Description

  • The keyboard was not dismissed since the FocusNode was recreated on each rebuild, making it useless

How was this tested

  • Navigate to a search result from pages page without dismissing the keyboard and confirm that it gets auto-dismissed
  • Pressing the done button dismisses the keyboard as well

@alextran1502 alextran1502 merged commit ff19aea into main Sep 4, 2025
57 checks passed
@alextran1502 alextran1502 deleted the fix/keyboard-dismiss-places-searcg branch September 4, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
changelog:bugfix 📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenlong-tanwen @alextran1502