feat(mobile): add to albums from existing albums #21554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quick update, it seems I missed running the format script. I added a commit with the format (which added one empty line). |
alextran1502
approved these changes
Sep 3, 2025
alextran1502
reviewed
Sep 3, 2025
mobile/lib/presentation/widgets/bottom_sheet/remote_album_bottom_sheet.widget.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What:
Adds the option to add a selection of photos to an Album when picking items from existing Albums. I have implemented the feature in both legacy and beta timelines.
Why:
This feature currently exists in the web app and is missing in the mobile app. It is very useful because selecting photos from the main "Photos" timeline tab can be a lot of work. For instance people who sync Instagram, Whatsapp and Screenshots albums, will have everything mixed on the main timeline/tab, while the "Recents" album on the "Albums" tab only have photos that were taken with the phone camera. Other than that users can always want to create/improve albums out of other existing albums.
Github Issue:
I did not find a Github issue. But I just had my girlfriend complaining that she does not use the Immich app to share photos with me, because she finds it too time consuming to have to deselect photos from the timeline, before adding to our shared Albums. So, I am basically fixing her complaints. Also, it adds feature parity with web app, so it should be intuitive to web app users anyway. It's not a weird flow that people are not used to already.
How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)