feat: Show metadata in duplicates utility#21342
Closed
ollioddi wants to merge 2 commits intoimmich-app:mainfrom
Closed
feat: Show metadata in duplicates utility#21342ollioddi wants to merge 2 commits intoimmich-app:mainfrom
ollioddi wants to merge 2 commits intoimmich-app:mainfrom
Conversation
Member
|
Closes #14844 |
Member
|
Thank you for the reminder, can you help rebase and clean it up so it fits with the new UI, then we can work together to get this merged |
4 tasks
9 tasks
Author
|
@alextran1502 had time now to revisit. Created #26328 since my fork was ~2300 commits behind. I'd very much like feedback on the UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an enhancement to the duplicates utility, by allowing the user to view metadata of the assets in a duplicate group.
It makes it easier to pick the right photo when resolving duplicates by showing key metadata for each asset. You can choose which fields to display and whether to show all selected fields or only the ones that differ between assets.
Picking the wrong copy (e.g., one with a newer file-created date) can misplace photos on the timeline. Seeing the relevant metadata, and especially dates, helps ensure the correct asset is kept. It also avoids loosing metadata in the process.
Whats changed:
How Has This Been Tested?
I've tested on my rather large collection of duplicates :-) It really is a nice feature because it allows me to keep what i want. The "diff" option is also very handy, as to not overload the user by showing irrelevant information.
Screenshots (if appropriate)
After and before below (I apologize for the wrong order of the side-by-side screenshots)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)