fix(mobile): person birthday viewing/editing#20731
Merged
alextran1502 merged 3 commits intomainfrom Aug 6, 2025
Merged
Conversation
shenlong-tanwen
approved these changes
Aug 6, 2025
alextran1502
approved these changes
Aug 6, 2025
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
* fix: edit birthday dialog * chore: convert age to "x years old" format * fix: lint --------- Co-authored-by: Alex <alex.tran1502@gmail.com>
sbiswas-s2
added a commit
to sbiswas-s2/immich
that referenced
this pull request
Aug 19, 2025
* fix: edit birthday dialog * chore: convert age to "x years old" format * fix: lint --------- Co-authored-by: Alex <alex.tran1502@gmail.com>"
sbiswas-s2
added a commit
to sbiswas-s2/immich
that referenced
this pull request
Aug 20, 2025
sbiswas-s2
added a commit
to sbiswas-s2/immich
that referenced
this pull request
Aug 20, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show "Add birthday" if person does not have birthday set instead of "Edit birthday"
Fixed looping date selector
Changes age view to "_ years old" style labels
Fixes #20529
How Has This Been Tested?
Tested with people that have birthday and don't have birthday set
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)