feat(mobile): load user certificates for Android#20033
Closed
richardlt wants to merge 1 commit intoimmich-app:mainfrom
Closed
feat(mobile): load user certificates for Android#20033richardlt wants to merge 1 commit intoimmich-app:mainfrom
richardlt wants to merge 1 commit intoimmich-app:mainfrom
Conversation
Contributor
|
Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label. |
Collaborator
|
Duplicate of #19830 |
Author
|
Yes.. didn't noticed this other PR and that its author is also the one that forked the Flutter module to retrieve certificates 😅 |
Member
We do plan to merge the other PR in so I'll close this for now. Thanks a lot for working on this! Feel free to work on the other open issues with the app :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi, I made this PR to load Android User Certificates in the Flutter HTTP Client. This is useful when using your own Root Certificate installed on your phone. The only workaround for now is to enable the Self Signed Certificate option in the App.
The code in this PR was inspired from https://github.com/jfly/flutter_user_certificates_android
How Has This Been Tested?
I was able to run the App with this patch in the Android Emulator to validate that the Certificate was loaded and properly used.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)