Skip to content

feat(mobile): load user certificates for Android#20033

Closed
richardlt wants to merge 1 commit intoimmich-app:mainfrom
richardlt:feat/android-user-certificates
Closed

feat(mobile): load user certificates for Android#20033
richardlt wants to merge 1 commit intoimmich-app:mainfrom
richardlt:feat/android-user-certificates

Conversation

@richardlt
Copy link

Description

Hi, I made this PR to load Android User Certificates in the Flutter HTTP Client. This is useful when using your own Root Certificate installed on your phone. The only workaround for now is to enable the Self Signed Certificate option in the App.

The code in this PR was inspired from https://github.com/jfly/flutter_user_certificates_android

How Has This Been Tested?

I was able to run the App with this patch in the Android Emulator to validate that the Certificate was loaded and properly used.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@github-actions
Copy link
Contributor

Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label.

@mmomjian
Copy link
Collaborator

Duplicate of #19830

@mmomjian mmomjian marked this as a duplicate of #19830 Jul 20, 2025
@richardlt
Copy link
Author

Yes.. didn't noticed this other PR and that its author is also the one that forked the Flutter module to retrieve certificates 😅
Anyway, you can close my PR if the other one is already planned to be merged.
Thank you.

@shenlong-tanwen
Copy link
Member

Yes.. didn't noticed this other PR and that its author is also the one that forked the Flutter module to retrieve certificates 😅 Anyway, you can close my PR if the other one is already planned to be merged. Thank you.

We do plan to merge the other PR in so I'll close this for now. Thanks a lot for working on this! Feel free to work on the other open issues with the app :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants