feat: open asset from activities and disable focusing activity text field#19976
feat: open asset from activities and disable focusing activity text field#19976Tumist76 wants to merge 7 commits intoimmich-app:mainfrom
Conversation
|
@Tumist76 Apologies for not getting back earlier. I was away on a vacation last week and came back yesterday. Between the last update here and now, the app has been migrated to a new timeline which is supposed to be the one where we will be focusing our efforts on. We are reworking all the other pages to work with the new timeline backed by the SQLite database. The text field has been migrated to a new widget named We are also migrating away from using Hooks to Stateful widgets instead. If you could update the |
|
Any update on this? |
af326e9 to
b58460e
Compare
I have migrated to the new timeline. The new timeline already does not show the keyboard when opening the activity page so that has been removed. |
|
Before merging, this could have conflicts with #22894 if it is merged before this PR. that PR changes the signature of AssetViewer.setAsset to include a TimelineType. |
|
@bwees Can we also add back the change to disable the keyboard from automatically opening up when entering the Activities page? The PR from the author had this before the new timeline port |
Done! |
fb780b8 to
d766878
Compare
feat: remove autofocus on activity page open feat: made only activity tile thumbnail image tappable
d766878 to
5c59b5a
Compare
|
The chat-styled activity refactor from #23185 handled this as as part of the other changes in it. Thanks a lot for the PR, and sorry that we had to close it. Please feel free to work on any other issues or enhancements in the app. |
Description
This PR adds the ability to open assets directly from the activity page when they are mentioned in activities (likes or comments). Previously, users could only view activities but couldn't easily navigate to the actual asset being referenced. They could only manually locate the asset in album view.
Additionally, it disables autofocus on textfield and keyboard appearance on entering the activities page. Decision was made because of two things. First, IMO, it hurts UX - leaving a comment is not the most popular action for user then opening activities view and none of the apps do this. Second, it triggers keyboard after updating activities view on entering asset viewer.
How Has This Been Tested?
Video summary
screen-20250716-224557.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)