-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat(web): Add upload to stack action #19842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
84be1b6
feat(web): Add upload to stack action
Sese-Schneider ed4afc3
Event handling and translation
Sese-Schneider 291b29e
Update asset viewer instead
Sese-Schneider 67d7da9
lint, improve upload return type
Sese-Schneider 94469ba
Add suggestions from code review
Sese-Schneider 076a596
Merge branch 'main' into add-to-stack-action
Sese-Schneider 719aa21
Merge remote-tracking branch 'origin/main' into add-to-stack-action
Sese-Schneider 39dae82
Merge branch 'main' into add-to-stack-action
Sese-Schneider 781b8a5
Resolve merge conflicts
Sese-Schneider 0efa839
Apply suggestions from code review
Sese-Schneider 5ab0917
Merge branch 'main' into add-to-stack-action
Sese-Schneider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
web/src/lib/components/asset-viewer/actions/add-to-stack-action.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <script lang="ts"> | ||
| import MenuOption from '$lib/components/shared-components/context-menu/menu-option.svelte'; | ||
| import { AssetAction } from '$lib/constants'; | ||
| import { openFileUploadDialog } from '$lib/utils/file-uploader'; | ||
| import { createStack, type AssetResponseDto, type StackResponseDto } from '@immich/sdk'; | ||
| import { mdiUploadMultiple } from '@mdi/js'; | ||
| import { t } from 'svelte-i18n'; | ||
| import type { OnAction } from './action'; | ||
|
|
||
| interface Props { | ||
| asset: AssetResponseDto; | ||
| stack: StackResponseDto | null; | ||
| onAction: OnAction; | ||
| } | ||
|
|
||
| let { asset, stack, onAction }: Props = $props(); | ||
|
|
||
| const handleAddUploadToStack = async () => { | ||
| const newAssetIds = await openFileUploadDialog({ multiple: true }); | ||
| // Including the old stacks primary asset ID ensures that all assets of the | ||
| // old stack are automatically included in the new stack. | ||
| const primaryAssetId = stack?.primaryAssetId ?? asset.id; | ||
|
|
||
| // First asset in the list will become the new primary asset. | ||
| const assetIds = [primaryAssetId, ...newAssetIds]; | ||
|
|
||
| const newStack = await createStack({ | ||
| stackCreateDto: { | ||
| assetIds, | ||
| }, | ||
| }); | ||
|
|
||
| onAction({ type: AssetAction.STACK, stack: newStack }); | ||
| }; | ||
| </script> | ||
|
|
||
| <MenuOption icon={mdiUploadMultiple} onClick={handleAddUploadToStack} text={$t('add_upload_to_stack')} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.