fix(web): wait for image to load before playing memories. #19757
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the memory viewer to not start the progress bar until the image is done loading. Keep existing behavior for videos.
Comment on lines
+260
to
+261
| handlePromiseError(handleAction('resetAndPlay', 'reset')); | ||
| handlePromiseError(handleAction('resetAndPlay', 'play')); |
There was a problem hiding this comment.
You have changed the first parameter here. Why?
There was a problem hiding this comment.
The first parameter is only for logging, previously it was initPlayer[AssetViewOpen] since that was the name of the method it was contained in.
|
Fixes #11727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the memory viewer to not start the progress bar until the image is done loading. Keep existing behavior for videos.
Fixes #18578
Fixes #19598
Fixes #11727
How Has This Been Tested?
Tested locally in chrome while throttling network speed.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)