Skip to content

fix: use GPSLongitudeRef and GPSLatitudeRef EXIF fields#18403

Closed
ktbloomq wants to merge 2 commits intoimmich-app:mainfrom
ktbloomq:main
Closed

fix: use GPSLongitudeRef and GPSLatitudeRef EXIF fields#18403
ktbloomq wants to merge 2 commits intoimmich-app:mainfrom
ktbloomq:main

Conversation

@ktbloomq
Copy link

Description

Fix EXIF parsing for GPS. Fixes GPSLongitudeRef and GPSLatitudeRef from being ignored,
changes made:

  • update exiftool-vendored to 30.0.0
  • configure ExifToolOptions to enable geolocation: required to consider GPSLongitudeRef and GPSLatitudeRef

Fixes #13053

How Has This Been Tested?

Using the cli, upload test.png and test.xmp from here. In the latest stable version the image incorrectly positions itself in China. Applying the change places the image in the correctly intended test location: Washington DC

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@bo0tzz bo0tzz changed the title fix GPSLongitudeRef and GPSLatitudeRef bug fix: use GPSLongitudeRef and GPSLatitudeRef EXIF fields May 21, 2025
@danieldietzler
Copy link
Member

Hey, given e2e tests are failing I'm guessing there were more (breaking) changes in the upgrade. Please address those.

@danieldietzler
Copy link
Member

Closing given there wasn't any activity. @ktbloomq if you start working on this again we can re-open the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPS geo location wrong: GPSLongitudeRef and GPSLatitudeRef not taken into account

3 participants