fix: use GPSLongitudeRef and GPSLatitudeRef EXIF fields#18403
Closed
ktbloomq wants to merge 2 commits intoimmich-app:mainfrom
Closed
fix: use GPSLongitudeRef and GPSLatitudeRef EXIF fields#18403ktbloomq wants to merge 2 commits intoimmich-app:mainfrom
ktbloomq wants to merge 2 commits intoimmich-app:mainfrom
Conversation
Member
|
Hey, given e2e tests are failing I'm guessing there were more (breaking) changes in the upgrade. Please address those. |
Member
|
Closing given there wasn't any activity. @ktbloomq if you start working on this again we can re-open the PR :) |
3 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix EXIF parsing for GPS. Fixes GPSLongitudeRef and GPSLatitudeRef from being ignored,
changes made:
Fixes #13053
How Has This Been Tested?
Using the cli, upload test.png and test.xmp from here. In the latest stable version the image incorrectly positions itself in China. Applying the change places the image in the correctly intended test location: Washington DC
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)