feat: use SvelteKit served by nest.js#17758
Conversation
96bb3b6 to
9bbb55c
Compare
alextran1502
left a comment
There was a problem hiding this comment.
Cool! Have you tested the Prod build? Have you looked into how this supports subpath?
|
For my understanding, this moves away from static file serving to instead run sveltekit's serverside code, right? |
Getting this to run was entire based on removing one error after the other in prod lol
Jason and I talked about this (he had the idea we could even do this without actually SSR'ing everything). The issue currently is that we cannot change the base path (https://svelte.dev/docs/kit/configuration#paths) after it's built. With this we (seemingly) have a couple of options to get a dynamic base path. |
Correct. However we don't actually enable SSR for any of the websites. We only change the way we serve the files. |
7739a8d to
f9180a7
Compare
f9180a7 to
38376c5
Compare
|
Web sucks too badly to enable SSR for shared links again. Will need to refactor that first. |
|
Closing for now |
|
Will re-address this when web is in a better place. |
This enables us to implement hosting Immich on a sub path.
In the future we could maybe also look into removing the web container.