Skip to content

feat: use SvelteKit served by nest.js#17758

Closed
danieldietzler wants to merge 1 commit intomainfrom
feat/adapter-node
Closed

feat: use SvelteKit served by nest.js#17758
danieldietzler wants to merge 1 commit intomainfrom
feat/adapter-node

Conversation

@danieldietzler
Copy link
Copy Markdown
Member

@danieldietzler danieldietzler commented Apr 21, 2025

This enables us to implement hosting Immich on a sub path.

In the future we could maybe also look into removing the web container.

Copy link
Copy Markdown
Member

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Have you tested the Prod build? Have you looked into how this supports subpath?

@bo0tzz
Copy link
Copy Markdown
Member

bo0tzz commented Apr 21, 2025

For my understanding, this moves away from static file serving to instead run sveltekit's serverside code, right?

@danieldietzler
Copy link
Copy Markdown
Member Author

danieldietzler commented Apr 21, 2025

Have you tested the Prod build?

Getting this to run was entire based on removing one error after the other in prod lol

Have you looked into how this supports subpath?

Jason and I talked about this (he had the idea we could even do this without actually SSR'ing everything). The issue currently is that we cannot change the base path (https://svelte.dev/docs/kit/configuration#paths) after it's built. With this we (seemingly) have a couple of options to get a dynamic base path.

@danieldietzler
Copy link
Copy Markdown
Member Author

For my understanding, this moves away from static file serving to instead run sveltekit's serverside code, right?

Correct. However we don't actually enable SSR for any of the websites. We only change the way we serve the files.

@danieldietzler danieldietzler force-pushed the feat/adapter-node branch 2 times, most recently from 7739a8d to f9180a7 Compare April 25, 2025 10:43
@danieldietzler danieldietzler marked this pull request as draft April 25, 2025 13:08
@danieldietzler
Copy link
Copy Markdown
Member Author

Web sucks too badly to enable SSR for shared links again. Will need to refactor that first.

@zackpollard
Copy link
Copy Markdown
Member

Closing for now

@danieldietzler
Copy link
Copy Markdown
Member Author

Will re-address this when web is in a better place.

@jrasm91 jrasm91 deleted the feat/adapter-node branch July 17, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants