fix(web): cancel people merge selection: do not show "Change name successfully" notification

[afv]

• Change a person name and select one of the existing;
• "Are these the same person?" modal appears;
• Cancel; the "Change name successfully" notification appears (without the name being changed).

This PR fixes the notification showing if the user cancels the merge.

[alextran1502]

I believe the correct fix is to consolidate the onClose and onReject into a single callback i.e onClose in the merge-suggestion-model.svelte component

[afv]

We have to distinguish between

1. "Cancel, I clicked the wrong person" when explicitly clicking an existing name (button onclick={() => handleSuggestPeople(person)}), and
2. "Cancel, the suggested person that exists with the same name is not the same person, so keep/continue the name change", when the modal appears when you give a name that already exists.

Will your suggestion of consolidating the onClose and onReject work with the two cases?

[alextran1502]

The onReject callback from the merge-suggestion-model.svelte is called when you click the No button, essentially having the same effect as closing the model. I don't see the difference there. So I think it should just be handled as an onClose event

[alextran1502]

Ah wait, nvm, I get what you mean. Your solution is fine

[afv]

handleNameChange opens the modal if you enter a name that already exists:

If you say No and onReject just closes the modal, the name won't be saved.

[afv]

Ah wait, nvm, I get what you mean. Your solution is fine

Thanks!