Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use node-addon-api v8 #15438

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

dotlambda
Copy link
Contributor

Building sharp from source fails with

error: 'NewOrCopy' is not a member of 'Napi::Buffer<char>'

otherwise.

Building sharp [from source][1] fails with

    error: 'NewOrCopy' is not a member of 'Napi::Buffer<char>'

otherwise.

[1]: https://sharp.pixelplumbing.com/install\#building-from-source
@dotlambda dotlambda changed the title fix(deps): use node-addon-api v6 fix(deps): use node-addon-api v8 Jan 19, 2025
@mertalev mertalev merged commit 97ec3b1 into immich-app:main Jan 19, 2025
35 of 36 checks passed
@dotlambda dotlambda deleted the node-addon-api branch January 19, 2025 16:28
ExceptionsOccur pushed a commit to ExceptionsOccur/immich that referenced this pull request Jan 20, 2025
vladd11 pushed a commit to vladd11/immich that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants