fix: reverse geocoding data import don't use unlogged tables #15136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackpollard
requested review from
mertalev
and removed request for
danieldietzler
jrasm91
approved these changes
Jan 7, 2025
alextran1502
approved these changes
Jan 7, 2025
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Jan 13, 2025
arctic-foxtato
pushed a commit
to arctic-foxtato/immich
that referenced
this pull request
Jan 14, 2025
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using unlogged tables can mean if the database crashes or system hard resets before the database flushes to disk, the data in the unlogged reverse geocoding tables was lost and unrecoverable because there is no WAL. This is also more likely due to the resource intensive nature of the import and indexing process, as well as lots of jobs potentially starting on boot.
Performance implications of this change were minimal on my dev machine, import time changed from 6 seconds to 7 seconds for the rows (excluding indexing time which remained the same).
I also managed to reproduce this problem by force killing the database container straight after the import completed, which resulted in an empty table.