feat(web): create tag on the fly #14726
Conversation
bo0tzz
changed the title
|
Hello, thank you for the PR. Can you help fix the e2e test? |
MehringTing
force-pushed
the
b-feat-create-tag-on-the-fly
branch
2 times, most recently
from
5fa8885 to
34197f8
Compare
| @@ -50,20 +55,22 @@ | |||
| <FullScreenModal title={$t('tag_assets')} icon={mdiTag} onClose={onCancel}> | |||
| <div class="text-sm"> | |||
| <p> | |||
| <FormatMessage key="tag_not_found_question"> | |||
| <!-- <FormatMessage key="tag_not_found_question"> | |||
There was a problem hiding this comment.
Can you remove this unused code?
There was a problem hiding this comment.
I just tested the PR and it works well.
Can you help address the comments? And what do you think about making a wrapper component for the combobox and adding specific tag creation handling in that wrapper component instead of adding those logics to the combobox?
clean unused code and add comments
I refer to the design of the element plus for the select component.
|
#12179 (comment)