fix(server): /search/random
failing with certain options
#13040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current query only works when no relations are requested. When they are, TypeORM does an additional query with a
distinct
clause that conflicts with the sort order. This PR makes a few changes to address this:UNION ALL
, but the fact that TypeORM does two queries makes it infeasible right nowwithPeople
option that's currently broken/search/random
endpoint since it makes things more complicated and there isn't a compelling use-case for it hereFixes #13021
How Has This Been Tested?
Tested that the endpoint works with a combination of
withExif
,withStacked
andwithPeople
and returns different rows in each call.